[GitHub] [ignite-3] alievmirza commented on a change in pull request #293: IGNITE-15278

[GitBox <gi...@apache.org>]

alievmirza commented on a change in pull request #293:
URL: https://github.com/apache/ignite-3/pull/293#discussion_r694586585



##########
File path: modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java
##########
@@ -92,13 +353,132 @@ public SqlQueryProcessor queryEngine() {
      * @return Node configuration.
      */
     public ConfigurationRegistry nodeConfiguration() {
-        return nodeConfigurationMgr.configurationRegistry();
+        return nodeCfgMgr.configurationRegistry();
     }
 
     /**
      * @return Cluster configuration.
      */
     public ConfigurationRegistry clusterConfiguration() {
-        return clusterConfigurationMgr.configurationRegistry();
+        return clusterCfgMgr.configurationRegistry();
+    }
+
+    /**
+     * @return Client handler module.
+     */
+    public ClientHandlerModule clientHandlerModule() {
+        return clientHandlerModule;
+    }
+
+    /**
+     * Checks node status. If it's STOPPING then prevents further starting and throws NodeStoppingException that will

Review comment:
       Let's put here {@link Status#STOPPING}

##########
File path: modules/network-api/src/main/java/org/apache/ignite/network/ClusterServiceFactory.java
##########
@@ -24,7 +27,13 @@
      * Creates a new {@link ClusterService} using the provided context. The created network will not be in the "started" state.
      *
      * @param context Cluster context.
+     * @param nodeConfiguration Node configuration.
+     * @param nodeFinderSupplier  Supplier that provides node finder for discovering the initial cluster members.

Review comment:
       redundant whitespace 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org