You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "abhishake (JIRA)" <ji...@apache.org> on 2007/09/18 18:57:44 UTC

[jira] Created: (OFBIZ-1255) product not found for product id

product not found for product id
--------------------------------

                 Key: OFBIZ-1255
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
             Project: OFBiz
          Issue Type: Bug
          Components: ecommerce
    Affects Versions: SVN trunk
         Environment: Ubuntu 7.4
            Reporter: abhishake
             Fix For: SVN trunk


when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-1255) product not found for product id

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529740 ] 

Jacques Le Roux commented on OFBIZ-1255:
----------------------------------------

This is primarily related to OFBIZ-724

1st action
  http://tinyurl.com/39u6om
  http://svn.apache.org/viewvc?view=rev&revision=508502

then
http://svn.apache.org/viewvc?view=rev&revision=509955
 
finally
  http://tinyurl.com/2vsfoq
  http://svn.apache.org/viewvc?view=rev&revision=509990

Also related OFBIZ-729

> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png, Screenshot2.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-1255) product not found for product id

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1255:
-----------------------------------

    Priority: Minor  (was: Major)

> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png, Screenshot2.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-1255) product not found for product id

Posted by "roller boyz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

roller boyz updated OFBIZ-1255:
-------------------------------


Thank you abhishake.
It's very cool. 

> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png, Screenshot2.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-1255) product not found for product id

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552342 ] 

Jacques Le Roux commented on OFBIZ-1255:
----------------------------------------

Cool Raj,

Waiting for your patch

> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png, Screenshot2.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (OFBIZ-1255) product not found for product id

Posted by "abhishake (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529920 ] 

abhishake edited comment on OFBIZ-1255 at 9/24/07 10:20 AM:
------------------------------------------------------------

To solve this issue, I have written a JavaScript function in the header.ftl i.e.

<script type="text/javascript">
         function doSubmit(formName){

          //remove the jsessionid if present in th url
           var action1 = document.forms[formName].action;
           		if(action1.indexOf(";") > -1){
					action1 = action1.substr(0,action1.indexOf(";") );
				
				}
                //take url in the browser and substring the url with the start of ~
          	var action2 = document.location.href;
          		if(action2){
	          		if(action2.indexOf("~") > -1){
	          			var queryString = action2.substr(action2.indexOf("~") - 1);
	          			action1 = action1 + queryString ;
	          		
	          		}
          		}
          	document.forms[formName].action = action1;
		document.forms[formName].submit();
          
          }
        </script>   


also login part is put under a form with following modification (resolves the problem faced after login)

<form method="post" action="<@ofbizUrl>checkLogin<#if   requestAttributes._CURRENT_VIEW_?exists>/${requestAttributes._CURRENT_VIEW_}</#...@ofbizUrl>" name="loginForm">

    	<a href="javascript:doSubmit('loginForm');">${uiLabelMap.CommonLogin}</a>
            	
</form>

and set locale part is modified as, (to resolve the problem while setting locale)

<form method="post" action="<@ofbizUrl>setSessionLocale<#if requestAttributes._CURRENT_VIEW_?exists>/${requestAttributes._CURRENT_VIEW_}</#...@ofbizUrl>" name="localeForm">
           
              <select name="locale">
                <#list availableLocales as availableLocale>
                    <#assign langAttr = availableLocale.toString()?replace("_", "-")> 
                    <#assign langDir = "ltr">
                    <#if "ar.iw"?contains(langAttr?substring(0, 2)) && langAttr?substring(0, 2) =    docLangAttr?substring(0, 2)>
                        <#assign langDir = "rtl">
                    </#if>
                    <option lang="${langAttr}" dir="${langDir}" value="${availableLocale.toString()}"<#if locale.toString() = availableLocale.toString()> selected="selected"</#if>>${availableLocale.getDisplayName(locale)}</option>
                </#list>
              </select>
              <input type="button" value="${uiLabelMap.CommonSet}" onclick="doSubmit('localeForm')"/>
   </form>


I tested this and I found everything is working fine with it, also as per david suggestion, I tried doing this in the same way as add to cart funtionality.

Please advise me whether I have done this correctly.
also, I am new to ofbiz and I don't know how to submit patch. 

      was (Author: abhishake):
    To solve this issue, I have written a JavaScript function in the header.ftl i.e.

<script type="text/javascript">
         function doSubmit(formName){

          //remove the jsessionid if present in th url
           var action1 = document.forms[formName].action;
           		if(action1.indexOf(";") > -1){
					action1 = action1.substr(0,action1.indexOf(";") );
				
				}
                //take url in the browser and substring the url with the start of ~
          	var action2 = document.location.href;
          		if(action2){
	          		if(action2.indexOf("~") > -1){
	          			var queryString = action2.substr(action2.indexOf("~") - 1);
	          			action1 = action1 + queryString ;
	          		
	          		}
          		}
          	document.forms[formName].action = action1;
		document.forms[formName].submit();
          
          }
        </script>   


also login part is put under a form with following modification (resolves the problem faced after login)

<form method="post" action="<@ofbizUrl>checkLogin<#if   requestAttributes._CURRENT_VIEW_?exists>/${requestAttributes._CURRENT_VIEW_}</#...@ofbizUrl>" name="loginForm">

    	<a href="javascript:doSubmit('loginForm');">${uiLabelMap.CommonLogin}</a>
            	
</form>

and set locale part is modified as,

<form method="post" action="<@ofbizUrl>setSessionLocale<#if requestAttributes._CURRENT_VIEW_?exists>/${requestAttributes._CURRENT_VIEW_}</#...@ofbizUrl>" name="localeForm">
           
              <select name="locale">
                <#list availableLocales as availableLocale>
                    <#assign langAttr = availableLocale.toString()?replace("_", "-")> 
                    <#assign langDir = "ltr">
                    <#if "ar.iw"?contains(langAttr?substring(0, 2)) && langAttr?substring(0, 2) =    docLangAttr?substring(0, 2)>
                        <#assign langDir = "rtl">
                    </#if>
                    <option lang="${langAttr}" dir="${langDir}" value="${availableLocale.toString()}"<#if locale.toString() = availableLocale.toString()> selected="selected"</#if>>${availableLocale.getDisplayName(locale)}</option>
                </#list>
              </select>
              <input type="button" value="${uiLabelMap.CommonSet}" onclick="doSubmit('localeForm')"/>
   </form>


I tested this and I found everything is working fine with it, also as per david suggestion, I tried doing this in the same way as add to cart funtionality.

Please advise me whether I have done this correctly.
also, I am new to ofbiz and I don't know how to submit patch. 
  
> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png, Screenshot2.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-1255) product not found for product id

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552281 ] 

Jacques Le Roux commented on OFBIZ-1255:
----------------------------------------

I'm not sure we want to use this as is, as it does not update the header when you logout : "Welcome... " remains. So it does introduces an inconsistency.
Moreover it does not solve other similar issues, when changing language for instance, you always "Product not found for Product ID !"

If no enhancement is proposed in a patch I will close this issue soon.

> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png, Screenshot2.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-1255) product not found for product id

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560221#action_12560221 ] 

Jacques Le Roux commented on OFBIZ-1255:
----------------------------------------

Hi Raj,

Any news ?

> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png, Screenshot2.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-1255) product not found for product id

Posted by "Raj Saini (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560247#action_12560247 ] 

Raj Saini commented on OFBIZ-1255:
----------------------------------

Hi Jacques,

I will look into this during the weekend.



> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png, Screenshot2.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-1255) product not found for product id

Posted by "abhishake (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

abhishake updated OFBIZ-1255:
-----------------------------

    Attachment: productdetail.png

> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-1255) product not found for product id

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531379 ] 

Jacques Le Roux commented on OFBIZ-1255:
----------------------------------------

This is an interesting approach. It's to late this weekend to test it and I wonder what other commiters think about it ? If nobody see an issue in this proposition, I will test and hopefully commit it.

To create a patch please follow this link http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices.

Depending of you development environment you might be interested by this link too http://docs.ofbiz.org/display/OFBIZ/FAQ+-+Tips+-+Cookbook+-+HowTo#FAQ-Tips-Cookbook-HowTo-PatchingOnWindows

> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png, Screenshot2.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OFBIZ-1255) product not found for product id

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1255:
--------------------------------------

    Assignee: Jacques Le Roux

> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png, Screenshot2.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OFBIZ-1255) product not found for product id

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1255.
----------------------------------

    Resolution: Later

> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png, Screenshot2.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-1255) product not found for product id

Posted by "abhishake (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

abhishake updated OFBIZ-1255:
-----------------------------

    Attachment: Screenshot2.png

> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png, Screenshot2.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-1255) product not found for product id

Posted by "abhishake (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

abhishake updated OFBIZ-1255:
-----------------------------


I have been looking into the code to find the cause of the problem. I found that below snippet of code in the ordermgr/WEB-INF/actions/entry/catalog/product.bsh  is commented out. 

/*
 * NOTE JLR 20070221 this should be done using the same method than in add to cart. I will do it like that and   remove all this after.
 *
if (productId != null) {
    previousParams = session.getAttribute("_PREVIOUS_PARAMS_"); 
    if (previousParams != null && previousParams.length() > 0) {
        previousParams = UtilHttp.stripNamedParamsFromQueryString(previousParams, UtilMisc.toList("product_id"));
        previousParams = previousParams + "&product_id=" + productId;
        System.err.println("product id is null------------"+productId);
    } else {
        previousParams = "product_id=" + productId;
        System.err.println("product id is not null------------");
    }
    session.setAttribute("_PREVIOUS_PARAMS_", previousParams);    // for login
    context.put("previousParams", previousParams);
}   
*/

Uncommenting the above piece of code resolves this problem (product not found for product id).  However, product navigation (previous| next) stops working on product detail screen for the current product. Comments on top of code say something which I am not able to understand. Can someone explain what is the intent  of this code comment.






> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png, Screenshot2.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-1255) product not found for product id

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531380 ] 

Jacques Le Roux commented on OFBIZ-1255:
----------------------------------------

Ok, I just saw that you use Ubuntu (great choice ;o) forget my last link : no interest for you

> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png, Screenshot2.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-1255) product not found for product id

Posted by "Raj Saini (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552308 ] 

Raj Saini commented on OFBIZ-1255:
----------------------------------

I have it working on our local branch (modified). I will work on this and submit the proper patch. Please keep the issue open.

> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png, Screenshot2.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (OFBIZ-1255) product not found for product id

Posted by "abhishake (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529738 ] 

abhishake edited comment on OFBIZ-1255 at 9/23/07 4:11 AM:
-----------------------------------------------------------

I have been looking into the code to find the cause of the problem. I found that below snippet of code in the ordermgr/WEB-INF/actions/entry/catalog/product.bsh  is commented out. 

/*
 * NOTE JLR 20070221 this should be done using the same method than in add to cart. I will do it like that and   remove all this after.
 *
if (productId != null) {
    previousParams = session.getAttribute("_PREVIOUS_PARAMS_"); 
    if (previousParams != null && previousParams.length() > 0) {
        previousParams = UtilHttp.stripNamedParamsFromQueryString(previousParams, UtilMisc.toList("product_id"));
        previousParams = previousParams + "&product_id=" + productId;
        
    } else {
        previousParams = "product_id=" + productId;
        
    }
    session.setAttribute("_PREVIOUS_PARAMS_", previousParams);    // for login
    context.put("previousParams", previousParams);
}   
*/

Uncommenting the above piece of code resolves this problem (product not found for product id).  However, product navigation (previous| next) stops working on product detail screen for the current product. Comments on top of code say something which I am not able to understand. Can someone explain what is the intent  of this code comment.






      was (Author: abhishake):
    I have been looking into the code to find the cause of the problem. I found that below snippet of code in the ordermgr/WEB-INF/actions/entry/catalog/product.bsh  is commented out. 

/*
 * NOTE JLR 20070221 this should be done using the same method than in add to cart. I will do it like that and   remove all this after.
 *
if (productId != null) {
    previousParams = session.getAttribute("_PREVIOUS_PARAMS_"); 
    if (previousParams != null && previousParams.length() > 0) {
        previousParams = UtilHttp.stripNamedParamsFromQueryString(previousParams, UtilMisc.toList("product_id"));
        previousParams = previousParams + "&product_id=" + productId;
        System.err.println("product id is null------------"+productId);
    } else {
        previousParams = "product_id=" + productId;
        System.err.println("product id is not null------------");
    }
    session.setAttribute("_PREVIOUS_PARAMS_", previousParams);    // for login
    context.put("previousParams", previousParams);
}   
*/

Uncommenting the above piece of code resolves this problem (product not found for product id).  However, product navigation (previous| next) stops working on product detail screen for the current product. Comments on top of code say something which I am not able to understand. Can someone explain what is the intent  of this code comment.





  
> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png, Screenshot2.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-1255) product not found for product id

Posted by "abhishake (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

abhishake updated OFBIZ-1255:
-----------------------------


To solve this issue, I have written a JavaScript function in the header.ftl i.e.

<script type="text/javascript">
         function doSubmit(formName){

          //remove the jsessionid if present in th url
           var action1 = document.forms[formName].action;
           		if(action1.indexOf(";") > -1){
					action1 = action1.substr(0,action1.indexOf(";") );
				
				}
                //take url in the browser and substring the url with the start of ~
          	var action2 = document.location.href;
          		if(action2){
	          		if(action2.indexOf("~") > -1){
	          			var queryString = action2.substr(action2.indexOf("~") - 1);
	          			action1 = action1 + queryString ;
	          		
	          		}
          		}
          	document.forms[formName].action = action1;
		document.forms[formName].submit();
          
          }
        </script>   


also login part is put under a form with following modification (resolves the problem faced after login)

<form method="post" action="<@ofbizUrl>checkLogin<#if   requestAttributes._CURRENT_VIEW_?exists>/${requestAttributes._CURRENT_VIEW_}</#...@ofbizUrl>" name="loginForm">

    	<a href="javascript:doSubmit('loginForm');">${uiLabelMap.CommonLogin}</a>
            	
</form>

and set locale part is modified as,

<form method="post" action="<@ofbizUrl>setSessionLocale<#if requestAttributes._CURRENT_VIEW_?exists>/${requestAttributes._CURRENT_VIEW_}</#...@ofbizUrl>" name="localeForm">
           
              <select name="locale">
                <#list availableLocales as availableLocale>
                    <#assign langAttr = availableLocale.toString()?replace("_", "-")> 
                    <#assign langDir = "ltr">
                    <#if "ar.iw"?contains(langAttr?substring(0, 2)) && langAttr?substring(0, 2) =    docLangAttr?substring(0, 2)>
                        <#assign langDir = "rtl">
                    </#if>
                    <option lang="${langAttr}" dir="${langDir}" value="${availableLocale.toString()}"<#if locale.toString() = availableLocale.toString()> selected="selected"</#if>>${availableLocale.getDisplayName(locale)}</option>
                </#list>
              </select>
              <input type="button" value="${uiLabelMap.CommonSet}" onclick="doSubmit('localeForm')"/>
   </form>


I tested this and I found everything is working fine with it, also as per david suggestion, I tried doing this in the same way as add to cart funtionality.

Please advise me whether I have done this correctly.
also, I am new to ofbiz and I don't know how to submit patch. 

> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>             Fix For: Release Branch 4.0
>
>         Attachments: productdetail.png, Screenshot2.png
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-1255) product not found for product id

Posted by "abhishake (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

abhishake updated OFBIZ-1255:
-----------------------------

        Fix Version/s:     (was: SVN trunk)
                       Release Branch 4.0
    Affects Version/s:     (was: SVN trunk)
                       Release Branch 4.0

> product not found for product id
> --------------------------------
>
>                 Key: OFBIZ-1255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 4.0
>         Environment: Ubuntu 7.4
>            Reporter: abhishake
>             Fix For: Release Branch 4.0
>
>
> when  we get login  after visiting  the product detail screen i.e I should see the same product detail after login but this is not happening instead I see a message " product not found for product id". This problem doesn't come when you add the product to a cart from product detail screen and then get login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.