You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2018/07/18 01:33:31 UTC

Re: Review Request 66820: Added per-framework 'subscribed' metric and helpers.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66820/
-----------------------------------------------------------

(Updated July 18, 2018, 1:33 a.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Greg Mann, Jie Yu, and Vinod Kone.


Summary (updated)
-----------------

Added per-framework 'subscribed' metric and helpers.


Bugs: MESOS-8919
    https://issues.apache.org/jira/browse/MESOS-8919


Repository: mesos


Description (updated)
-------

Added per-framework 'subscribed' metric and helpers.


Diffs (updated)
-----

  src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224 
  src/master/master.cpp 487ee349ef0cd78903ff6bcdea3f24688810cdc5 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/66820/diff/8/

Changes: https://reviews.apache.org/r/66820/diff/7-8/


Testing
-------


Thanks,

Gilbert Song


Re: Review Request 66820: Added per-framework 'subscribed' metric and helpers.

Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66820/#review206223
-----------------------------------------------------------


Ship it!




Ship It!

- Gastón Kleiman


On July 17, 2018, 6:33 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66820/
> -----------------------------------------------------------
> 
> (Updated July 17, 2018, 6:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-8919
>     https://issues.apache.org/jira/browse/MESOS-8919
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added per-framework 'subscribed' metric and helpers.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224 
>   src/master/master.cpp 487ee349ef0cd78903ff6bcdea3f24688810cdc5 
>   src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
>   src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
> 
> 
> Diff: https://reviews.apache.org/r/66820/diff/8/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>