You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Thomas Neidhart <th...@gmail.com> on 2012/05/05 11:52:52 UTC

Re: svn commit: r1333397 - in /commons/proper/codec/trunk/src/main/java/org/apache/commons/codec: ./ binary/ digest/ language/ language/bm/ net/

On 05/03/2012 12:21 PM, sebb@apache.org wrote:
> Author: sebb
> Date: Thu May  3 10:21:11 2012
> New Revision: 1333397
> 
> URL: http://svn.apache.org/viewvc?rev=1333397&view=rev
> Log:
> Add thread-safety Javadoc
> 
> Modified:
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/CharEncoding.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/Charsets.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/StringEncoderComparator.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/BinaryCodec.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Hex.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/StringUtils.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/B64.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/Crypt.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/Md5Crypt.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/Sha2Crypt.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/UnixCrypt.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/AbstractCaverphone.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/Caverphone1.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/Caverphone2.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/ColognePhonetic.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/DoubleMetaphone.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/Metaphone.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/Nysiis.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/RefinedSoundex.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/Soundex.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/SoundexUtils.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Languages.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/ResourceConstants.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/BCodec.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QCodec.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/RFC1522Codec.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/URLCodec.java
>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/Utils.java

+1 and thanks.

Do you still investigate the BeiderMorseEncoder / PhoneticEngine for
thread-safety?

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1333397 - in /commons/proper/codec/trunk/src/main/java/org/apache/commons/codec: ./ binary/ digest/ language/ language/bm/ net/

Posted by Gary Gregory <ga...@gmail.com>.
On Wed, May 23, 2012 at 6:40 PM, Konstantin Kolinko
<kn...@gmail.com>wrote:

> 2012/5/5 Thomas Neidhart <th...@gmail.com>:
> > On 05/03/2012 12:21 PM, sebb@apache.org wrote:
> >> Author: sebb
> >> Date: Thu May  3 10:21:11 2012
> >> New Revision: 1333397
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1333397&view=rev
> >> Log:
> >> Add thread-safety Javadoc
> >>
> >> Modified:
> >>
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/CharEncoding.java
> >>
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/Charsets.java
> >> (...)
>
>  *
> + * This class is immutable and thread-safe.
> + *
>
> This needs explicit "<p>" before it to be formatted nicely. Otherwise
> it will be just appended to the previous paragraph.
>

Fixed in SVN. Thank you!

Gary


>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: svn commit: r1333397 - in /commons/proper/codec/trunk/src/main/java/org/apache/commons/codec: ./ binary/ digest/ language/ language/bm/ net/

Posted by Konstantin Kolinko <kn...@gmail.com>.
2012/5/5 Thomas Neidhart <th...@gmail.com>:
> On 05/03/2012 12:21 PM, sebb@apache.org wrote:
>> Author: sebb
>> Date: Thu May  3 10:21:11 2012
>> New Revision: 1333397
>>
>> URL: http://svn.apache.org/viewvc?rev=1333397&view=rev
>> Log:
>> Add thread-safety Javadoc
>>
>> Modified:
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/CharEncoding.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/Charsets.java
>> (...)

  *
+ * This class is immutable and thread-safe.
+ *

This needs explicit "<p>" before it to be formatted nicely. Otherwise
it will be just appended to the previous paragraph.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1333397 - in /commons/proper/codec/trunk/src/main/java/org/apache/commons/codec: ./ binary/ digest/ language/ language/bm/ net/

Posted by sebb <se...@gmail.com>.
On 5 May 2012 10:52, Thomas Neidhart <th...@gmail.com> wrote:
> On 05/03/2012 12:21 PM, sebb@apache.org wrote:
>> Author: sebb
>> Date: Thu May  3 10:21:11 2012
>> New Revision: 1333397
>>
>> URL: http://svn.apache.org/viewvc?rev=1333397&view=rev
>> Log:
>> Add thread-safety Javadoc
>>
>> Modified:
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/CharEncoding.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/Charsets.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/StringEncoderComparator.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/BinaryCodec.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Hex.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/StringUtils.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/B64.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/Crypt.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/Md5Crypt.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/Sha2Crypt.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/UnixCrypt.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/AbstractCaverphone.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/Caverphone1.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/Caverphone2.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/ColognePhonetic.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/DoubleMetaphone.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/Metaphone.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/Nysiis.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/RefinedSoundex.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/Soundex.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/SoundexUtils.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Languages.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/ResourceConstants.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/BCodec.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QCodec.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/RFC1522Codec.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/URLCodec.java
>>     commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/Utils.java
>
> +1 and thanks.
>
> Do you still investigate the BeiderMorseEncoder / PhoneticEngine for
> thread-safety?

Their thread safety is documented already.

> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org