[GitHub] [arrow-datafusion] ozankabak commented on a diff in pull request #5342: Bug/union wrong casting

["ozankabak (via GitHub)" <gi...@apache.org>]

ozankabak commented on code in PR #5342:
URL: https://github.com/apache/arrow-datafusion/pull/5342#discussion_r1118160922


##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -238,13 +238,32 @@ fn comparison_binary_numeric_coercion(
         (_, Decimal128(_, _)) => get_comparison_common_decimal_type(rhs_type, lhs_type),
         (Float64, _) | (_, Float64) => Some(Float64),
         (_, Float32) | (Float32, _) => Some(Float32),
-        (Int64, _) | (_, Int64) => Some(Int64),
-        (Int32, _) | (_, Int32) => Some(Int32),
-        (Int16, _) | (_, Int16) => Some(Int16),
-        (Int8, _) | (_, Int8) => Some(Int8),
+        // start checking from Int64, that is the most inclusive integer type

Review Comment:
   Wouldn't that map (`Int32`, `Int16`) to `Int64`? I think @berkaysynnada's intent is to map to the narrowest correct type, which in this case would be `Int32`.
   
   I am not sure if the `match` pattern is the most succinct representation of the table in the PR text though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org