You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Sena0777 (via GitHub)" <gi...@apache.org> on 2023/03/27 09:44:44 UTC
[GitHub] [rocketmq] Sena0777 opened a new pull request, #6483: [ISSUE #6482]style: Rename the variable "filepath" to "filePath" on line 55 of PosixFileSegment.java
Sena0777 opened a new pull request, #6483:
URL: https://github.com/apache/rocketmq/pull/6483
… file tieredstore/src/main/java/org/apache/rocketmq/tieredstore/provider/posix/PosixFileSegment.java
**Make sure set the target branch to `develop`**
## What is the purpose of the change
<!--
If this PR fixes a GitHub issue, please add `fixes #<XXX>` or `closes #<XXX>`. Please refer to the documentation for more information:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-->
In the RocketMQ project, the variable name "filepath" on line 55 of the file tieredstore/src/main/java/org/apache/rocketmq/tieredstore/provider/posix/PosixFileSegment.java does not comply with the naming convention and should be renamed to "filePath" to conform with the Java coding standard. <!-- <xxx> replace with issue id -->
## Brief changelog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShadowySpirits commented on a diff in pull request #6483: [ISSUE #6482]style: Rename the variable "filepath" to "filePath" on line 55 of PosixFileSegment.java
Posted by "ShadowySpirits (via GitHub)" <gi...@apache.org>.
ShadowySpirits commented on code in PR #6483:
URL: https://github.com/apache/rocketmq/pull/6483#discussion_r1149143324
##########
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/provider/posix/PosixFileSegment.java:
##########
@@ -52,7 +52,7 @@ public class PosixFileSegment extends TieredFileSegment {
private static final String OPERATION_POSIX_WRITE = "write";
private final String basePath;
- private final String filepath;
+ private final String filePath;
Review Comment:
There is no need to make changes as "filepath" is widely used in many libraries, including the [Go standard library](https://pkg.go.dev/path/filepath). There has been a lot of discussion regarding the usage of "filepath" and "file path". As an example, I would like to quote one such discussion below.
> filepath, as an unhyphenated compound word, is generally used when discussing it as an entity (e.g., “You’ll need to set the filepath before writing out any data.”), but file path, as two words, is generally used when referring to a particular attribute of a file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] MieAh commented on pull request #6483: [ISSUE #6482]style: Rename the variable "filepath" to "filePath" on line 55 of PosixFileSegment.java
Posted by "MieAh (via GitHub)" <gi...@apache.org>.
MieAh commented on PR #6483:
URL: https://github.com/apache/rocketmq/pull/6483#issuecomment-1484855039
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Sena0777 commented on a diff in pull request #6483: [ISSUE #6482]style: Rename the variable "filepath" to "filePath" on line 55 of PosixFileSegment.java
Posted by "Sena0777 (via GitHub)" <gi...@apache.org>.
Sena0777 commented on code in PR #6483:
URL: https://github.com/apache/rocketmq/pull/6483#discussion_r1150053141
##########
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/provider/posix/PosixFileSegment.java:
##########
@@ -52,7 +52,7 @@ public class PosixFileSegment extends TieredFileSegment {
private static final String OPERATION_POSIX_WRITE = "write";
private final String basePath;
- private final String filepath;
+ private final String filePath;
Review Comment:
Thank you for providing a fresh perspective that I hadn't considered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] github-code-scanning[bot] commented on pull request #6483: [ISSUE #6482]style: Rename the variable "filepath" to "filePath" on line 55 of PosixFileSegment.java
Posted by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org>.
github-code-scanning[bot] commented on PR #6483:
URL: https://github.com/apache/rocketmq/pull/6483#issuecomment-1484848064
You have successfully added a new CodeQL configuration `.github/workflows/codeql_analysis.yml:CodeQL-Build`. As part of the setup process, we have scanned this repository and found 9 existing alerts. Please check the repository [Security tab](/apache/rocketmq/security/code-scanning?query=pr%3A6483+tool%3ACodeQL+is%3Aopen) to see all alerts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #6483: [ISSUE #6482]style: Rename the variable "filepath" to "filePath" on line 55 of PosixFileSegment.java
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #6483:
URL: https://github.com/apache/rocketmq/pull/6483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org