You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Stefan Guggisberg (JIRA)" <ji...@apache.org> on 2006/03/03 15:26:25 UTC

[jira] Created: (JCR-331) RepositoryConfig instance can not be reused once it has been passed to RepositoryImpl constructor

RepositoryConfig instance can not be reused once it has been passed to RepositoryImpl constructor
-------------------------------------------------------------------------------------------------

         Key: JCR-331
         URL: http://issues.apache.org/jira/browse/JCR-331
     Project: Jackrabbit
        Type: Improvement
  Components: config  
    Versions: 0.9    
 Environment: svn r382351
    Reporter: Stefan Guggisberg
    Priority: Minor
     Fix For: 1.0
 Attachments: reusable_config.patch

RepositoryConfig and other *Config classes maintain state apart from parsed configuration information;
specifically they instantiate FileSystem implementations based on their configurations. this makes it
for the config consumers very hard to control the lifecycle of such FileSystem instances as they need
to close the file systems on repository shutdown.

the following code illustrates the issue:

RepositoryConfig repConf = RepositoryConfig.create(configFile, repHomeDir);
RepositoryImpl rep = RepositoryImpl.create(repConf);
// ...
rep.shutdown();

rep = RepositoryImpl.create(repConf);   
// ==> repConfig (et al) contains references to FileSystem objects 
// that have been closed by previous rep.shutdown() call



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (JCR-331) RepositoryConfig instance can not be reused once it has been passed to RepositoryImpl constructor

Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JCR-331?page=all ]
     
Stefan Guggisberg closed JCR-331:
---------------------------------

    Resolution: Fixed

applied patch (svn r386078)

> RepositoryConfig instance can not be reused once it has been passed to RepositoryImpl constructor
> -------------------------------------------------------------------------------------------------
>
>          Key: JCR-331
>          URL: http://issues.apache.org/jira/browse/JCR-331
>      Project: Jackrabbit
>         Type: Improvement
>   Components: config
>     Versions: 0.9
>  Environment: svn r382351
>     Reporter: Stefan Guggisberg
>     Assignee: Stefan Guggisberg
>     Priority: Minor
>      Fix For: 1.1
>  Attachments: reusable_config.patch
>
> RepositoryConfig and other *Config classes maintain state apart from parsed configuration information;
> specifically they instantiate FileSystem implementations based on their configurations. this makes it
> for the config consumers very hard to control the lifecycle of such FileSystem instances as they need
> to close the file systems on repository shutdown.
> the following code illustrates the issue:
> RepositoryConfig repConf = RepositoryConfig.create(configFile, repHomeDir);
> RepositoryImpl rep = RepositoryImpl.create(repConf);
> // ...
> rep.shutdown();
> rep = RepositoryImpl.create(repConf);   
> // ==> repConfig (et al) contains references to FileSystem objects 
> // that have been closed by previous rep.shutdown() call

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (JCR-331) RepositoryConfig instance can not be reused once it has been passed to RepositoryImpl constructor

Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JCR-331?page=all ]

Stefan Guggisberg updated JCR-331:
----------------------------------

    Attachment: reusable_config.patch

attached patch for making *Config classes reusable

> RepositoryConfig instance can not be reused once it has been passed to RepositoryImpl constructor
> -------------------------------------------------------------------------------------------------
>
>          Key: JCR-331
>          URL: http://issues.apache.org/jira/browse/JCR-331
>      Project: Jackrabbit
>         Type: Improvement
>   Components: config
>     Versions: 0.9
>  Environment: svn r382351
>     Reporter: Stefan Guggisberg
>     Priority: Minor
>      Fix For: 1.0
>  Attachments: reusable_config.patch
>
> RepositoryConfig and other *Config classes maintain state apart from parsed configuration information;
> specifically they instantiate FileSystem implementations based on their configurations. this makes it
> for the config consumers very hard to control the lifecycle of such FileSystem instances as they need
> to close the file systems on repository shutdown.
> the following code illustrates the issue:
> RepositoryConfig repConf = RepositoryConfig.create(configFile, repHomeDir);
> RepositoryImpl rep = RepositoryImpl.create(repConf);
> // ...
> rep.shutdown();
> rep = RepositoryImpl.create(repConf);   
> // ==> repConfig (et al) contains references to FileSystem objects 
> // that have been closed by previous rep.shutdown() call

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (JCR-331) RepositoryConfig instance can not be reused once it has been passed to RepositoryImpl constructor

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JCR-331?page=all ]

Jukka Zitting updated JCR-331:
------------------------------

    Fix Version: 1.1
                     (was: 1.0)

> RepositoryConfig instance can not be reused once it has been passed to RepositoryImpl constructor
> -------------------------------------------------------------------------------------------------
>
>          Key: JCR-331
>          URL: http://issues.apache.org/jira/browse/JCR-331
>      Project: Jackrabbit
>         Type: Improvement
>   Components: config
>     Versions: 0.9
>  Environment: svn r382351
>     Reporter: Stefan Guggisberg
>     Priority: Minor
>      Fix For: 1.1
>  Attachments: reusable_config.patch
>
> RepositoryConfig and other *Config classes maintain state apart from parsed configuration information;
> specifically they instantiate FileSystem implementations based on their configurations. this makes it
> for the config consumers very hard to control the lifecycle of such FileSystem instances as they need
> to close the file systems on repository shutdown.
> the following code illustrates the issue:
> RepositoryConfig repConf = RepositoryConfig.create(configFile, repHomeDir);
> RepositoryImpl rep = RepositoryImpl.create(repConf);
> // ...
> rep.shutdown();
> rep = RepositoryImpl.create(repConf);   
> // ==> repConfig (et al) contains references to FileSystem objects 
> // that have been closed by previous rep.shutdown() call

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (JCR-331) RepositoryConfig instance can not be reused once it has been passed to RepositoryImpl constructor

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/JCR-331?page=comments#action_12370522 ] 

Jukka Zitting commented on JCR-331:
-----------------------------------

+1 looks good

> RepositoryConfig instance can not be reused once it has been passed to RepositoryImpl constructor
> -------------------------------------------------------------------------------------------------
>
>          Key: JCR-331
>          URL: http://issues.apache.org/jira/browse/JCR-331
>      Project: Jackrabbit
>         Type: Improvement
>   Components: config
>     Versions: 0.9
>  Environment: svn r382351
>     Reporter: Stefan Guggisberg
>     Priority: Minor
>      Fix For: 1.1
>  Attachments: reusable_config.patch
>
> RepositoryConfig and other *Config classes maintain state apart from parsed configuration information;
> specifically they instantiate FileSystem implementations based on their configurations. this makes it
> for the config consumers very hard to control the lifecycle of such FileSystem instances as they need
> to close the file systems on repository shutdown.
> the following code illustrates the issue:
> RepositoryConfig repConf = RepositoryConfig.create(configFile, repHomeDir);
> RepositoryImpl rep = RepositoryImpl.create(repConf);
> // ...
> rep.shutdown();
> rep = RepositoryImpl.create(repConf);   
> // ==> repConfig (et al) contains references to FileSystem objects 
> // that have been closed by previous rep.shutdown() call

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (JCR-331) RepositoryConfig instance can not be reused once it has been passed to RepositoryImpl constructor

Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JCR-331?page=all ]

Stefan Guggisberg reassigned JCR-331:
-------------------------------------

    Assign To: Stefan Guggisberg

> RepositoryConfig instance can not be reused once it has been passed to RepositoryImpl constructor
> -------------------------------------------------------------------------------------------------
>
>          Key: JCR-331
>          URL: http://issues.apache.org/jira/browse/JCR-331
>      Project: Jackrabbit
>         Type: Improvement
>   Components: config
>     Versions: 0.9
>  Environment: svn r382351
>     Reporter: Stefan Guggisberg
>     Assignee: Stefan Guggisberg
>     Priority: Minor
>      Fix For: 1.1
>  Attachments: reusable_config.patch
>
> RepositoryConfig and other *Config classes maintain state apart from parsed configuration information;
> specifically they instantiate FileSystem implementations based on their configurations. this makes it
> for the config consumers very hard to control the lifecycle of such FileSystem instances as they need
> to close the file systems on repository shutdown.
> the following code illustrates the issue:
> RepositoryConfig repConf = RepositoryConfig.create(configFile, repHomeDir);
> RepositoryImpl rep = RepositoryImpl.create(repConf);
> // ...
> rep.shutdown();
> rep = RepositoryImpl.create(repConf);   
> // ==> repConfig (et al) contains references to FileSystem objects 
> // that have been closed by previous rep.shutdown() call

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira