[GitHub] [bahir-flink] gyfora commented on a change in pull request #78: Kudu Connector rework

[GitBox <gi...@apache.org>]

gyfora commented on a change in pull request #78:
URL: https://github.com/apache/bahir-flink/pull/78#discussion_r420849206



##########
File path: flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/batch/KuduInputFormatTest.java
##########
@@ -73,7 +73,8 @@ void testInputFormatWithProjection() throws Exception {
     private List<Row> readRows(KuduTableInfo tableInfo, String... fieldProjection) throws Exception {
         String masterAddresses = harness.getMasterAddressesAsString();
         KuduReaderConfig readerConfig = KuduReaderConfig.Builder.setMasters(masterAddresses).build();
-        KuduRowInputFormat inputFormat = new KuduRowInputFormat(readerConfig, tableInfo, new ArrayList<>(), Arrays.asList(fieldProjection));
+        KuduRowInputFormat inputFormat = new KuduRowInputFormat(readerConfig, tableInfo, new ArrayList<>(),
+                fieldProjection == null ? null : Arrays.asList(fieldProjection));

Review comment:
       we should also add a test that covers this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org