You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Neville Dipale (JIRA)" <ji...@apache.org> on 2019/06/21 14:22:00 UTC

[jira] [Resolved] (ARROW-4886) [Rust] Inconsistent behaviour with casting sliced primitive array to list array

     [ https://issues.apache.org/jira/browse/ARROW-4886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Neville Dipale resolved ARROW-4886.
-----------------------------------
    Resolution: Fixed

Resolved by [https://github.com/apache/arrow/commit/9ea6da3b38e1ccff73966934e4248c3073ad2444]

[~wesmckinn], didn't see that it wasn't marked as resolved.

> [Rust] Inconsistent behaviour with casting sliced primitive array to list array
> -------------------------------------------------------------------------------
>
>                 Key: ARROW-4886
>                 URL: https://issues.apache.org/jira/browse/ARROW-4886
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Rust
>    Affects Versions: 0.12.0
>            Reporter: Neville Dipale
>            Assignee: Neville Dipale
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.14.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> [~csun] I was going through the C++ cast implementation to see if I've missed anything, and I noticed that ListCastKernel ([https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/cast.cc#L665]) doesn't support casting non-zero-offset arrays. So I investigated what happens in Rust ARROW-4865. I found an inconsistency where inheriting the incoming array's offset could lead us to read invalid data.
> I tried fixing it, but found that a buffer that I expected to be invalid was being returned as valid, but returning invalid data.
> I've currently disabled casting primitive to array where the offset is not zero, and I'd like to wait for ARROW-4853 so I can see how sliced lists behave, and fix this inconsistency. That might only happen in 0.14, so I'm fine with that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)