[GitHub] [airflow] ashb commented on a change in pull request #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit…

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit…
URL: https://github.com/apache/airflow/pull/5564#discussion_r302983727
 
 

 ##########
 File path: tests/contrib/hooks/test_spark_submit_hook.py
 ##########
 @@ -364,7 +365,8 @@ def test_resolve_connection_spark_home_not_set_connection(self):
 
     def test_resolve_connection_spark_binary_set_connection(self):
         # Given
-        hook = SparkSubmitHook(conn_id='spark_binary_set')
+        hook = SparkSubmitHook(conn_id='spark_binary_set',
+                               spark_binary='custom-spark-submit')
 
 Review comment:
   This test should pass without this change (as the spark binary was set in the connection)
   
   We need a _new_ test that passes something _other_ than `custom-spark-binary` here and make sure that is used instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services