You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/09 22:14:51 UTC
[GitHub] [flink] bowenli86 commented on a change in pull request #9039: [FLINK-13170][table-planner] Planner should get table factory from ca…
bowenli86 commented on a change in pull request #9039: [FLINK-13170][table-planner] Planner should get table factory from ca…
URL: https://github.com/apache/flink/pull/9039#discussion_r301815920
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/PlannerBase.scala
##########
@@ -241,7 +241,20 @@ abstract class PlannerBase(
case Some(s) if JavaScalaConversionUtil.toScala(s.getCatalogTable)
.exists(_.isInstanceOf[CatalogTable]) =>
- val sinkProperties = s.getCatalogTable.get().asInstanceOf[CatalogTable].toProperties
+ val catalog = catalogManager.getCatalog(s.getTablePath.get(0))
+ val catalogTable = s.getCatalogTable.get().asInstanceOf[CatalogTable]
+ if (catalog.isPresent && catalog.get().getTableFactory.isPresent) {
Review comment:
seems to me `catalog` is always present? otherwise line 244 will throw exceptions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services