You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "D Tim Cummings (Jira)" <ji...@apache.org> on 2022/02/13 01:00:00 UTC
[jira] [Updated] (TAP5-2705) Fix warning Could not add object with duplicate id 'tapestry.css'
[ https://issues.apache.org/jira/browse/TAP5-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
D Tim Cummings updated TAP5-2705:
---------------------------------
Attachment: JavaScriptModule.diff
> Fix warning Could not add object with duplicate id 'tapestry.css'
> -----------------------------------------------------------------
>
> Key: TAP5-2705
> URL: https://issues.apache.org/jira/browse/TAP5-2705
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.5.0, 5.6.0, 5.6.1, 5.6.2, 5.7.0, 5.6.3, 5.7.1, 5.7.2, 5.6.4, 5.7.3, 5.8.0
> Reporter: D Tim Cummings
> Priority: Minor
> Labels: bootstrap, core, stylesheet, warn
> Attachments: JavaScriptModule.diff
>
>
> For the last few versions of tapestry, the following warning messages would show in the logs
> {{WARN org.apache.tapestry5.modules.JavaScriptModule.CoreJavaScriptStack Could not add object with duplicate id 'tapestry.css'. The duplicate object has been ignored.}}
> {{WARN org.apache.tapestry5.modules.JavaScriptModule.CoreJavaScriptStack Could not add object with duplicate id 'exception-frame.css'. The duplicate object has been ignored.}}
> {{WARN org.apache.tapestry5.modules.JavaScriptModule.CoreJavaScriptStack Could not add object with duplicate id 'tapestry-console.css'. The duplicate object has been ignored.}}
> {{WARN org.apache.tapestry5.modules.JavaScriptModule.CoreJavaScriptStack Could not add object with duplicate id 'tree.css'. The duplicate object has been ignored.}}
> I think this is because the method addCoreStylesheets in JavaScriptModule is being called multiple times but it should only be called once. This is mainly related to adding bootstrap 4 and font-awesome. I have created a diff which shows what changes are needed so that addCoreStylesheets is only called once. Unfortunately I haven't been able to test it as I haven't worked out yet how to build tapestry from source.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)