You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/13 21:49:42 UTC

[GitHub] [flink] dmvk commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

dmvk commented on code in PR #21467:
URL: https://github.com/apache/flink/pull/21467#discussion_r1047786569


##########
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java:
##########
@@ -2896,7 +2896,8 @@ private TaskExecutorTestingContext createTaskExecutorTestingContext(
                                 .setTaskStateManager(stateStoresManager)
                                 .setTaskChangelogStoragesManager(changelogStoragesManager)
                                 .build(),
-                        HEARTBEAT_SERVICES,
+                        // prevent heartbeat timeouts from failing the tests focused on other aspects
+                        new HeartbeatServices(60_000L, 60_000L),

Review Comment:
   Would it make sense to disable heartbeats entirely instead of relying on higher timeouts?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org