You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@commons.apache.org by GitBox <gi...@apache.org> on 2019/02/17 08:07:05 UTC

[GitHub] kinow edited a comment on issue #54: Code cleanup

kinow edited a comment on issue #54: Code cleanup
URL: https://github.com/apache/commons-io/pull/54#issuecomment-464307076
 
 
   Looks good to me! Much more readable! I only would need to consult the documentation (and perhaps other devs) regarding removing exception from public methods. I am not sure if that's OK for (binary&feature) backward compatibility.
   
   Also needs to be updated to fix conflicts with master branch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org