You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by cjpearson <gi...@git.apache.org> on 2017/03/21 15:16:55 UTC
[GitHub] cordova-plugin-camera pull request #257: CB-12953: (android) move management...
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/257
CB-12953: (android) move management of FileProvider out of the camera plugin
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
It allows multiple plugins to use the FileProvider. Each plugin that needs a provider path can add it using the config-file element. Another plugin will update the AndroidManifest and create the provider_paths file.
I've created a stub for this other plugin at https://github.com/cjpearson/cordova-plugin-file-provider so it builds correctly. I'm not sure if this other plugin should be a new plugin or added to an existing plugin.
### What testing has been done on this change?
Tested locally with cordova-android 6.1.2.
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cjpearson/cordova-plugin-camera provider_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/257.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #257
----
commit 37f0a54dbdb1c16c019c6683f519278de0d2e584
Author: Connor Pearson <cp...@b2wsoftware.com>
Date: 2017-03-21T14:04:09Z
CB-12953: (android) move management of FileProvider out of the camera plugin
commit bfb150efea8297406f06c12a1e0631b4ffae91f8
Author: Connor Pearson <cp...@b2wsoftware.com>
Date: 2017-03-21T15:10:00Z
use github link
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #257: CB-12593: (android) move management of Fil...
Posted by cjpearson <gi...@git.apache.org>.
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/257
@infil00p, I'm not very familiar with the internals of cordova-android. What do you mean by a tooling issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #257: CB-12953: (android) move management of Fil...
Posted by cjpearson <gi...@git.apache.org>.
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/257
Thanks for the feedback. I agree that it should go under the cordova umbrella somewhere. I just wanted to show a working example in the PR.
We have an internal plugin in our project that also uses the FileProvider and a provider_paths file. Attempting to upgrade the camera plugin to 2.3.1 fails the build with a duplicate element error. The only work around is to define both paths in one of the plugins which makes them dependent on each other and means we have to maintain a modified version of the camera plugin.
Sorry, I messed up the title. The JIRA issue is [here](https://issues.apache.org/jira/browse/CB-12593).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #257: CB-12953: (android) move management of Fil...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/257
I'm not sure we can merge this PR in as it relies on a non-Apache plugin. We would have to move that file provider plugin under the Cordova umbrella. Thoughts @stevengill ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #257: CB-12593: (android) move management of Fil...
Posted by cjpearson <gi...@git.apache.org>.
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/257
I think https://github.com/apache/cordova-plugin-camera/pull/274 may be a better solution. Closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #257: CB-12953: (android) move management of Fil...
Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/257
Cordova CI Build has completed successfully.
**Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/257/commits/bfb150efea8297406f06c12a1e0631b4ffae91f8)
**Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/148/)
| Builder Name | Console Output | Test Report | Device Logs |
| :---: | :---: | :---: | :---: |
| [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/148//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/148//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/148//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/148//PLATFORM=windows-10-store/artifact/) |
| [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/148//PLATFORM=ios-9.3/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/148//PLATFORM=ios-9.3/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/148//PLATFORM=ios-9.3/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/148//PLATFORM=ios-9.3/artifact/) |
| [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/148//PLATFORM=ios-10.0/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/148//PLATFORM=ios-10.0/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/148//PLATFORM=ios-10.0/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/148//PLATFORM=ios-10.0/artifact/) |
| [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/148//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/148//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/148//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/148//PLATFORM=android/artifact/) |
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #257: CB-12953: (android) move management of Fil...
Posted by cjpearson <gi...@git.apache.org>.
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/257
@stevengill could you take a look at this PR? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #257: CB-12593: (android) move management...
Posted by cjpearson <gi...@git.apache.org>.
Github user cjpearson closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/257
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #257: CB-12953: (android) move management of Fil...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/257
I can't find the issue in JIRA. At any rate, I don't think we should pull this in right now, and I think that we should probably move this into the android platform source in the future. Is there a specific use case that needs this plugin currently?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #257: CB-12593: (android) move management of Fil...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/257
@cjpearson After reading this, I can see this issue appearing even if we do move the management into cordova-android. This is a tooling issue that we're going to have to handle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org