[GitHub] [ozone] adoroszlai commented on pull request #3680: HDDS-7113. Support overriding response header values

[GitBox <gi...@apache.org>]

adoroszlai commented on PR #3680:
URL: https://github.com/apache/ozone/pull/3680#issuecomment-1216568846

   There are also quite a few checkstyle violations:
   
   ```
   hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java
    369: Line is longer than 80 characters (found 81).
   hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestObjectGet.java
    55: Name 'ContentType' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    56: Name 'ContentLanguage' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    57: Name 'Expires' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    58: Name 'CacheControl' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    59: Name 'ContentDisposition' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    60: Name 'ContentEncoding' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    62: Variable 'headers' must be private and have accessor methods.
    63: Variable 'rest' must be private and have accessor methods.
    64: Variable 'client' must be private and have accessor methods.
    65: Variable 'body' must be private and have accessor methods.
    130: 'body' hides a field.
   hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestOverrideResponseHeader.java
    45: Missing a Javadoc comment.
    48: Name 'ContentType1' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    49: Name 'ContentType2' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    50: Name 'ContentLanguage1' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    51: Name 'ContentLanguage2' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    52: Name 'Expires1' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    53: Name 'Expires2' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    54: Name 'CacheControl1' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    55: Name 'CacheControl2' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    56: Name 'ContentDisposition1' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    57: Name 'ContentDisposition2' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    59: Name 'ContentEncoding1' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    60: Name 'ContentEncoding2' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
    62: Variable 'headers' must be private and have accessor methods.
    63: Variable 'context' must be private and have accessor methods.
    64: Variable 'rest' must be private and have accessor methods.
    85: Line is longer than 80 characters (found 83).
    107: Line is longer than 80 characters (found 83).
    114: Line is longer than 80 characters (found 82).
   ```
   
   Can you please enable the "build-branch" workflow in your fork?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org