[GitHub] [pulsar] tisonkun commented on a diff in pull request #17881: PIP-209: Removed C++/Python clients from main repo

[GitBox <gi...@apache.org>]

tisonkun commented on code in PR #17881:
URL: https://github.com/apache/pulsar/pull/17881#discussion_r982995960


##########
docker/pulsar/pom.xml:
##########
@@ -58,55 +52,11 @@
       <id>docker</id>
       <properties>
         <docker.buildArg.PULSAR_TARBALL>target/pulsar-server-distribution-${project.version}-bin.tar.gz</docker.buildArg.PULSAR_TARBALL>
+        <docker.buildArg.PULSAR_CLIENT_PYTHON_VERSION>${pulsar.client.python.version}</docker.buildArg.PULSAR_CLIENT_PYTHON_VERSION>
         <docker.buildArg.UBUNTU_MIRROR>${env.UBUNTU_MIRROR}</docker.buildArg.UBUNTU_MIRROR>
       </properties>
       <build>
         <plugins>
-          <!-- build Python client, copy the wheel file and then build docker image -->

Review Comment:
   Cool!



##########
pulsar-functions/instance/pom.xml:
##########
@@ -238,9 +238,6 @@
                 <echo>building python instance</echo>
                 <mkdir dir="${basedir}/target/python-instance"/>
                 <copydir src="${basedir}/src/main/python" dest="${basedir}/target/python-instance"/>
-                <mkdir dir="${basedir}/target/python-instance/pulsar"/>
-                <copydir src="${basedir}/../../pulsar-client-cpp/python/pulsar"
-                         dest="${basedir}/target/python-instance/pulsar"/>

Review Comment:
   Doesn't this removal cause file not found?



##########
src/stage-release.sh:
##########
@@ -38,12 +38,6 @@ cp $PULSAR_PATH/distribution/offloaders/target/apache-pulsar-offloaders-$VERSION
 
 cp -r $PULSAR_PATH/distribution/io/target/apache-pulsar-io-connectors-$VERSION-bin $DEST_PATH/connectors
 
-mkdir $DEST_PATH/RPMS
-cp -r $PULSAR_PATH/pulsar-client-cpp/pkg/rpm/RPMS/x86_64/* $DEST_PATH/RPMS
-
-mkdir $DEST_PATH/DEB
-cp -r $PULSAR_PATH/pulsar-client-cpp/pkg/deb/BUILD/DEB/* $DEST_PATH/DEB

Review Comment:
   Perhaps file a subtask under #17724 about correspondingly update release guide.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org