[GitHub] [yunikorn-k8shim] yangwwei commented on a diff in pull request #586: [YUNIKORN-1723] Remove string comparison from hasReadyCondition() function

["yangwwei (via GitHub)" <gi...@apache.org>]

yangwwei commented on code in PR #586:
URL: https://github.com/apache/yunikorn-k8shim/pull/586#discussion_r1186615602


##########
pkg/cache/nodes.go:
##########
@@ -217,7 +217,7 @@ func (nc *schedulerNodes) schedulerNodeEventHandler() func(obj interface{}) {
 }
 
 func hasReadyCondition(node *v1.Node) bool {
-	if node != nil && node.Status.String() != "nil" {
+	if node != nil {

Review Comment:
   can node.Status be a nil? do we need
   ```
   node.Status != nil?
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org