You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/01/11 15:14:06 UTC

[GitHub] [maven-resolver] cstamas edited a comment on pull request #88: [MRESOLVER-157] Drop ServiceLocator

cstamas edited a comment on pull request #88:
URL: https://github.com/apache/maven-resolver/pull/88#issuecomment-758014197


   Another strange thing I just now realized: if you look at `org.eclipse.aether.impl.guice.AetherModule`, bindings are in `Singleton` scope. But, if you look at corresponding classes, they have `@Named` annontation only. This means, that **SISU will NOT treat them as singletons** (but as "prototype")! IMO, this is a mistake, as these components are meant to be singletons...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org