You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/03/03 19:52:56 UTC
Review Request 18703: Include picojson when building Mesos.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18703/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/Makefile.am 61d832b89132be2cc5b8ae9bbf743685464f78a4
Diff: https://reviews.apache.org/r/18703/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 18703: Include picojson when building Mesos.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On March 4, 2014, 8:06 p.m., Vinod Kone wrote:
> > +1 to sorting.
As mentioned in an earlier review, I'm going to defer the sorting to another review.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18703/#review36154
-----------------------------------------------------------
On March 3, 2014, 6:52 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18703/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 6:52 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 61d832b89132be2cc5b8ae9bbf743685464f78a4
>
> Diff: https://reviews.apache.org/r/18703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 18703: Include picojson when building Mesos.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18703/#review36154
-----------------------------------------------------------
Ship it!
+1 to sorting.
- Vinod Kone
On March 3, 2014, 6:52 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18703/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 6:52 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 61d832b89132be2cc5b8ae9bbf743685464f78a4
>
> Diff: https://reviews.apache.org/r/18703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 18703: Include picojson when building Mesos.
Posted by Charlie Carson <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18703/#review36062
-----------------------------------------------------------
src/Makefile.am
<https://reviews.apache.org/r/18703/#comment66894>
sorted for diff / merge purposes
src/Makefile.am
<https://reviews.apache.org/r/18703/#comment66895>
sorted for diff / merge purposes
- Charlie Carson
On March 3, 2014, 6:52 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18703/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 6:52 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 61d832b89132be2cc5b8ae9bbf743685464f78a4
>
> Diff: https://reviews.apache.org/r/18703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>