[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8369: [Generalized Pre-Aggregation] Initial Config wiring

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #8369:
URL: https://github.com/apache/pinot/pull/8369#discussion_r830412345



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java
##########
@@ -52,6 +52,7 @@
   private boolean _enableDynamicStarTreeCreation;
   private SegmentPartitionConfig _segmentPartitionConfig;
   private boolean _aggregateMetrics;
+  private List<String> _preAggregationConfigs;

Review comment:
       `String` is too limited. Let's add a class for it so that we can add more properties in the future.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org