You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/08/16 12:55:24 UTC
[GitHub] [kafka] dajac commented on a diff in pull request #12308: KAFKA-14009: update rebalance timeout in memory when consumers use st…
dajac commented on code in PR #12308:
URL: https://github.com/apache/kafka/pull/12308#discussion_r946735874
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala:
##########
@@ -1036,6 +1036,28 @@ class GroupCoordinatorTest {
assertEquals(Errors.NONE, syncGroupWithOldMemberIdResult.error)
}
+ @Test
+ def staticMemberJoinStorageWithUnknownPersistenceFailure(): Unit = {
+ val rebalanceResult = staticMembersJoinAndRebalance(leaderInstanceId, followerInstanceId)
+ val joinGroupResult = staticJoinGroupWithPersistence(groupId, JoinGroupRequest.UNKNOWN_MEMBER_ID, followerInstanceId, protocolType, protocolSuperset, clockAdvance = 1, 2 * DefaultSessionTimeout, 2 *DefaultSessionTimeout, appendRecordError = Errors.MESSAGE_TOO_LARGE)
+ checkJoinGroupResult(joinGroupResult,
+ Errors.UNKNOWN_SERVER_ERROR,
+ rebalanceResult.generation,
+ Set.empty,
+ Stable,
+ Some(protocolType))
+ assertNotEquals(None, groupCoordinator.groupManager.getGroup(groupId))
+ val group = groupCoordinator.groupManager.getGroup(groupId).get
+ val it = group.allMemberMetadata.iterator
+ while (it.hasNext) {
+ val member = it.next()
+ assertNotEquals(member.sessionTimeoutMs, 2 * DefaultSessionTimeout)
Review Comment:
I guess that we could remove the `assertNotEquals` assertions, no?
##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##########
@@ -438,7 +440,7 @@ class GroupCoordinator(val brokerId: Int,
case None => group.currentState match {
case PreparingRebalance =>
val member = group.get(memberId)
- updateMemberAndRebalance(group, member, protocols, s"Member ${member.memberId} joining group during ${group.currentState}; client reason: $reason", responseCallback)
+ updateMemberAndRebalance(group, member, protocols, rebalanceTimeoutMs, sessionTimeoutMs, s"Member ${member.memberId} joining group during ${group.currentState}; client reason: $reason", responseCallback)
Review Comment:
Updating the rebalance timeout and the session timeout in the non-static cases is not really necessary. I suppose that it does not hurt to do it.
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala:
##########
@@ -1036,6 +1036,28 @@ class GroupCoordinatorTest {
assertEquals(Errors.NONE, syncGroupWithOldMemberIdResult.error)
}
+ @Test
+ def staticMemberJoinStorageWithUnknownPersistenceFailure(): Unit = {
+ val rebalanceResult = staticMembersJoinAndRebalance(leaderInstanceId, followerInstanceId)
+ val joinGroupResult = staticJoinGroupWithPersistence(groupId, JoinGroupRequest.UNKNOWN_MEMBER_ID, followerInstanceId, protocolType, protocolSuperset, clockAdvance = 1, 2 * DefaultSessionTimeout, 2 *DefaultSessionTimeout, appendRecordError = Errors.MESSAGE_TOO_LARGE)
+ checkJoinGroupResult(joinGroupResult,
+ Errors.UNKNOWN_SERVER_ERROR,
+ rebalanceResult.generation,
+ Set.empty,
+ Stable,
+ Some(protocolType))
+ assertNotEquals(None, groupCoordinator.groupManager.getGroup(groupId))
Review Comment:
nit: Should we use `assertTrue(groupCoordinator.groupManager.getGroup(groupId).isDefined)`?
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##########
@@ -963,6 +963,8 @@ class GroupMetadataManagerTest {
assertEquals(Some(staticMemberId), group.currentStaticMemberId(groupInstanceId))
}
+
+
Review Comment:
nit: Could we revert this change?
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala:
##########
@@ -1036,6 +1036,28 @@ class GroupCoordinatorTest {
assertEquals(Errors.NONE, syncGroupWithOldMemberIdResult.error)
}
+ @Test
+ def staticMemberJoinStorageWithUnknownPersistenceFailure(): Unit = {
+ val rebalanceResult = staticMembersJoinAndRebalance(leaderInstanceId, followerInstanceId)
+ val joinGroupResult = staticJoinGroupWithPersistence(groupId, JoinGroupRequest.UNKNOWN_MEMBER_ID, followerInstanceId, protocolType, protocolSuperset, clockAdvance = 1, 2 * DefaultSessionTimeout, 2 *DefaultSessionTimeout, appendRecordError = Errors.MESSAGE_TOO_LARGE)
+ checkJoinGroupResult(joinGroupResult,
+ Errors.UNKNOWN_SERVER_ERROR,
+ rebalanceResult.generation,
+ Set.empty,
+ Stable,
+ Some(protocolType))
+ assertNotEquals(None, groupCoordinator.groupManager.getGroup(groupId))
+ val group = groupCoordinator.groupManager.getGroup(groupId).get
+ val it = group.allMemberMetadata.iterator
+ while (it.hasNext) {
+ val member = it.next()
+ assertNotEquals(member.sessionTimeoutMs, 2 * DefaultSessionTimeout)
+ assertEquals(member.sessionTimeoutMs, DefaultSessionTimeout)
+ assertNotEquals(member.rebalanceTimeoutMs, 2 * DefaultRebalanceTimeout)
+ assertEquals(member.rebalanceTimeoutMs, DefaultRebalanceTimeout)
+ }
+ }
+
Review Comment:
Could we also add a unit test which verifies that the happy case? I mean, when persisting the change succeeds.
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala:
##########
@@ -1036,6 +1036,28 @@ class GroupCoordinatorTest {
assertEquals(Errors.NONE, syncGroupWithOldMemberIdResult.error)
}
+ @Test
+ def staticMemberJoinStorageWithUnknownPersistenceFailure(): Unit = {
+ val rebalanceResult = staticMembersJoinAndRebalance(leaderInstanceId, followerInstanceId)
+ val joinGroupResult = staticJoinGroupWithPersistence(groupId, JoinGroupRequest.UNKNOWN_MEMBER_ID, followerInstanceId, protocolType, protocolSuperset, clockAdvance = 1, 2 * DefaultSessionTimeout, 2 *DefaultSessionTimeout, appendRecordError = Errors.MESSAGE_TOO_LARGE)
Review Comment:
Should the second `DefaultSessionTimeout` be `DefaultRebalanceTimeout`? Moreover, a space is missing after `*`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org