You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/08/19 23:50:05 UTC

[kudu-CR] [cmake] cleanup on clang version mapping on macOS

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18874


Change subject: [cmake] cleanup on clang version mapping on macOS
......................................................................

[cmake] cleanup on clang version mapping on macOS

This patch cleans up the code that determines compiler type and version
on macOS for Xcode-based LLVM/CLANG.  As it turns out, there is a well
documented mapping for clang versions: see [1] and [2].

I also updated unified regex patterns used to find versions of the
compiler in its version string.

References:
  [1] https://trac.macports.org/wiki/XcodeVersionInfo
  [2] https://en.wikipedia.org/wiki/Xcode#Version_history

Change-Id: I656dd4b20c7c852746861861f0741763b02609d5
---
M cmake_modules/CompilerInfo.cmake
1 file changed, 46 insertions(+), 28 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/18874/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I656dd4b20c7c852746861861f0741763b02609d5
Gerrit-Change-Number: 18874
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [cmake] cleanup on clang version mapping on macOS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18874

to look at the new patch set (#2).

Change subject: [cmake] cleanup on clang version mapping on macOS
......................................................................

[cmake] cleanup on clang version mapping on macOS

This patch cleans up the code that determines compiler type and version
on macOS for Xcode-based LLVM/CLANG.  As it turns out, there is a well
documented mapping for clang versions: see [1] and [2].

I also updated unified regex patterns used to find versions of the
compiler in its version string.

References:
  [1] https://trac.macports.org/wiki/XcodeVersionInfo
  [2] https://en.wikipedia.org/wiki/Xcode#Version_history

Change-Id: I656dd4b20c7c852746861861f0741763b02609d5
---
M cmake_modules/CompilerInfo.cmake
1 file changed, 83 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/18874/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I656dd4b20c7c852746861861f0741763b02609d5
Gerrit-Change-Number: 18874
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [cmake] cleanup on clang version mapping on macOS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18874 )

Change subject: [cmake] cleanup on clang version mapping on macOS
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I656dd4b20c7c852746861861f0741763b02609d5
Gerrit-Change-Number: 18874
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 09:45:47 +0000
Gerrit-HasComments: No

[kudu-CR] [cmake] cleanup on clang version mapping on macOS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18874 )

Change subject: [cmake] cleanup on clang version mapping on macOS
......................................................................

[cmake] cleanup on clang version mapping on macOS

This patch cleans up the code that determines compiler type and version
on macOS for Xcode-based LLVM/CLANG.  As it turns out, there is a well
documented mapping for clang versions: see [1] and [2].

I also updated unified regex patterns used to find versions of the
compiler in its version string.

References:
  [1] https://trac.macports.org/wiki/XcodeVersionInfo
  [2] https://en.wikipedia.org/wiki/Xcode#Version_history

Change-Id: I656dd4b20c7c852746861861f0741763b02609d5
Reviewed-on: http://gerrit.cloudera.org:8080/18874
Tested-by: Kudu Jenkins
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M cmake_modules/CompilerInfo.cmake
1 file changed, 83 insertions(+), 36 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Attila Bukor: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I656dd4b20c7c852746861861f0741763b02609d5
Gerrit-Change-Number: 18874
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>