You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/29 03:25:00 UTC

[GitHub] [pulsar] Jason918 opened a new pull request #13007: Fix race condition in FaultInjectionMetadataStore#programmedFailure

Jason918 opened a new pull request #13007:
URL: https://github.com/apache/pulsar/pull/13007


   
   ### Motivation
   `org.apache.pulsar.metadata.impl.FaultInjectionMetadataStore#programmedFailure` is not thread safe. 
   Multi threads can get the same failure at the same time (At Line 195), resulting one failure returned multiply times, which I believe is not the design purpose.
   
   ### Modifications
   
   Only return failure when remove is success. (`failures` is a thread safe list.)
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   
   This change is already covered by existing tests, such as ManagedLedgerErrorsTest
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
     
   - [x] `no-need-doc` 
   Bug fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #13007: Fix race condition in FaultInjectionMetadataStore#programmedFailure

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #13007:
URL: https://github.com/apache/pulsar/pull/13007


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 commented on pull request #13007: Fix race condition in FaultInjectionMetadataStore#programmedFailure

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #13007:
URL: https://github.com/apache/pulsar/pull/13007#issuecomment-981657913


   @eolivelli PTAL. It's the same issue you mentioned in #13005


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org