You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2015/10/13 20:32:10 UTC

[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

GitHub user marmbrus opened a pull request:

    https://github.com/apache/spark/pull/9100

    [SPARK-11090] [SQL] Constructor for Product types from InternalRow

    This is a first draft of the ability to construct expressions that will take a catalyst internal row and construct a Product (case class or tuple) that has fields with the correct names.  Support include:
     - Nested classes
     - Maps
     - Efficiently handling of arrays of primitive types
    
    Not yet supported:
     - Case classes that require custom collection types (i.e. List instead of Seq).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/marmbrus/spark productContructor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/9100.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9100
    
----
commit 1fde894606a11a515f32c7f573270773a2cd1225
Author: Michael Armbrust <mi...@databricks.com>
Date:   2015-10-08T20:16:18Z

    WIP constructors

commit e867cb9b553afce7f43a527f6a8c6595f9ba490c
Author: Michael Armbrust <mi...@databricks.com>
Date:   2015-10-08T20:45:10Z

    WIP

commit f10e93e31213123410399a9673b915121b1e09c0
Author: Michael Armbrust <mi...@databricks.com>
Date:   2015-10-08T22:43:28Z

    WIP

commit 0b24fed2c29289a1fd53d9828af01cbc2bd30110
Author: Michael Armbrust <mi...@databricks.com>
Date:   2015-10-10T20:24:23Z

    Draft of object constructor

commit 026ef4f3ad3216d7f26b850cbaba2220799a6354
Author: Michael Armbrust <mi...@databricks.com>
Date:   2015-10-10T20:25:15Z

    Merge remote-tracking branch 'origin/master' into productEncoder

commit 8cdcf60976eedc3a2785167fad7eeb2eb1a02661
Author: Michael Armbrust <mi...@databricks.com>
Date:   2015-10-13T18:29:38Z

    [SPARK-11090] [SQL] Constructor for Product types from InternalRow

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by davies <gi...@git.apache.org>.
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9100#discussion_r41938087
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala ---
    @@ -114,6 +118,298 @@ trait ScalaReflection {
           }
       }
     
    +  /**
    +   * Given a type `T` this function constructs and ObjectType that holds a class of type
    +   * Array[T].  Special handling is performed for primitive types to map them back to their raw
    +   * JVM form instead of the Scala Array that handles auto boxing.
    +   */
    +  def arrayClassFor(tpe: `Type`): DataType = {
    +    val cls = tpe match {
    +      case t if t <:< definitions.IntTpe => classOf[Array[Int]]
    +      case t if t <:< definitions.LongTpe => classOf[Array[Long]]
    +      case t if t <:< definitions.DoubleTpe => classOf[Array[Double]]
    +      case t if t <:< definitions.FloatTpe => classOf[Array[Float]]
    +      case t if t <:< definitions.ShortTpe => classOf[Array[Short]]
    +      case t if t <:< definitions.ByteTpe => classOf[Array[Byte]]
    +      case t if t <:< definitions.BooleanTpe => classOf[Array[Boolean]]
    +      case other =>
    +        // There is probably a better way to do this, but I couldn't find it...
    +        val elementType = dataTypeFor(other).asInstanceOf[ObjectType].cls
    +        java.lang.reflect.Array.newInstance(elementType, 1).getClass
    +
    +    }
    +    ObjectType(cls)
    +  }
    +
    +  /**
    +   * Returns an expression that can be used to construct an object of type `T` given a an input
    +   * row with a compatible schema.  Fields of the row will be extracted using UnresolvedAttributes
    +   * of the same name as the constructor arguments.  Nested classes will have their fields accessed
    +   * using UnresolvedExtractValue.
    +   */
    +  def constructorFor[T : TypeTag]: Expression = constructorFor(typeOf[T], None)
    +
    +  protected def constructorFor(
    +      tpe: `Type`,
    +      path: Option[Expression]): Expression = ScalaReflectionLock.synchronized {
    +
    +    /** Returns the current path with a sub-field extracted. */
    +    def addToPath(part: String) =
    +      path
    +        .map(p => UnresolvedExtractValue(p, expressions.Literal(part)))
    +        .getOrElse(UnresolvedAttribute(part))
    +
    +    /** Returns the current path or throws an error. */
    +    def getPath = path.getOrElse(sys.error("Constructors must start at a class type"))
    +
    +    tpe match {
    +      case t if !dataTypeFor(t).isInstanceOf[ObjectType] =>
    +        getPath
    +
    +      case t if t <:< localTypeOf[Option[_]] =>
    +        val TypeRef(_, _, Seq(optType)) = t
    +        val boxedType = optType match {
    +          // For primitive types we must manually box the primitive value.
    +          case t if t <:< definitions.IntTpe => Some(classOf[java.lang.Integer])
    +          case t if t <:< definitions.LongTpe => Some(classOf[java.lang.Long])
    +          case t if t <:< definitions.DoubleTpe => Some(classOf[java.lang.Double])
    +          case t if t <:< definitions.FloatTpe => Some(classOf[java.lang.Float])
    +          case t if t <:< definitions.ShortTpe => Some(classOf[java.lang.Short])
    +          case t if t <:< definitions.ByteTpe => Some(classOf[java.lang.Byte])
    +          case t if t <:< definitions.BooleanTpe => Some(classOf[java.lang.Boolean])
    +          case _ => None
    +        }
    +
    +        boxedType.map { boxedType =>
    --- End diff --
    
    Can we use different names for these two?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147829363
  
      [Test build #43663 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43663/consoleFull) for   PR 9100 at commit [`9fdcaae`](https://github.com/apache/spark/commit/9fdcaae7230ee1c1d9dbffbf9e931dadf4517a82).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147856494
  
     Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147849021
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147848820
  
      [Test build #43657 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43657/console) for   PR 9100 at commit [`8cdcf60`](https://github.com/apache/spark/commit/8cdcf60976eedc3a2785167fad7eeb2eb1a02661).
     * This patch **fails PySpark unit tests**.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `    def getPath = path.getOrElse(sys.error("Constructors must start at a class type"))`
      * `case class WrapOption(optionType: DataType, child: Expression)`
      * `class GenericArrayData(val array: Array[Any]) extends ArrayData `



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147827679
  
     Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147856525
  
    Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147806588
  
     Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147864773
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147858705
  
      [Test build #43675 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43675/consoleFull) for   PR 9100 at commit [`d1b6d01`](https://github.com/apache/spark/commit/d1b6d018527c2ef7163c3f599413fb1047d2cc0f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/9100


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147864775
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43663/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147827755
  
    Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147849023
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43657/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147864600
  
      [Test build #43663 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43663/console) for   PR 9100 at commit [`9fdcaae`](https://github.com/apache/spark/commit/9fdcaae7230ee1c1d9dbffbf9e931dadf4517a82).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `    def getPath = path.getOrElse(sys.error("Constructors must start at a class type"))`
      * `case class WrapOption(optionType: DataType, child: Expression)`
      * `class GenericArrayData(val array: Array[Any]) extends ArrayData `



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147849617
  
    High level approach LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147862505
  
      [Test build #43675 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43675/console) for   PR 9100 at commit [`d1b6d01`](https://github.com/apache/spark/commit/d1b6d018527c2ef7163c3f599413fb1047d2cc0f).
     * This patch **fails MiMa tests**.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `    def getPath = path.getOrElse(sys.error("Constructors must start at a class type"))`
      * `case class WrapOption(optionType: DataType, child: Expression)`
      * `class GenericArrayData(val array: Array[Any]) extends ArrayData `



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147806625
  
    Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147887272
  
    Going to merge and address any comments in a follow-up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147862557
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9100#discussion_r41922781
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/Encoder.scala ---
    @@ -17,6 +17,8 @@
     
     package org.apache.spark.sql.catalyst.encoders
     
    +import org.apache.spark.sql.catalyst.expressions.{Attribute, AttributeReference}
    --- End diff --
    
    nit order


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147809244
  
      [Test build #43657 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43657/consoleFull) for   PR 9100 at commit [`8cdcf60`](https://github.com/apache/spark/commit/8cdcf60976eedc3a2785167fad7eeb2eb1a02661).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11090] [SQL] Constructor for Product ty...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9100#issuecomment-147862559
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43675/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org