You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sj...@apache.org on 2023/01/28 12:27:14 UTC

[maven-enforcer] 01/01: [MENFORCER-462] Execute ReactorModuleConvergence only once

This is an automated email from the ASF dual-hosted git repository.

sjaranowski pushed a commit to branch MENFORCER-462
in repository https://gitbox.apache.org/repos/asf/maven-enforcer.git

commit 6a58ce5399da349e50aa4febf46fd210c74f875d
Author: Slawomir Jaranowski <s....@gmail.com>
AuthorDate: Sat Jan 28 13:26:46 2023 +0100

    [MENFORCER-462] Execute ReactorModuleConvergence only once
    
    Rule checks whole reactor of current build so can be executed once in session
---
 .../org/apache/maven/enforcer/rules/ReactorModuleConvergence.java   | 5 +++++
 .../apache/maven/enforcer/rules/ReactorModuleConvergenceTest.java   | 6 ++++++
 2 files changed, 11 insertions(+)

diff --git a/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/ReactorModuleConvergence.java b/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/ReactorModuleConvergence.java
index 651f12f..090b056 100644
--- a/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/ReactorModuleConvergence.java
+++ b/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/ReactorModuleConvergence.java
@@ -392,6 +392,11 @@ public final class ReactorModuleConvergence extends AbstractStandardEnforcerRule
         }
     }
 
+    @Override
+    public String getCacheId() {
+        return String.valueOf(toString().hashCode());
+    }
+
     @Override
     public String toString() {
         return String.format(
diff --git a/enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/ReactorModuleConvergenceTest.java b/enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/ReactorModuleConvergenceTest.java
index e3b6bc5..f7b2556 100644
--- a/enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/ReactorModuleConvergenceTest.java
+++ b/enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/ReactorModuleConvergenceTest.java
@@ -32,6 +32,7 @@ import org.codehaus.plexus.component.configurator.expression.ExpressionEvaluatio
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
@@ -221,6 +222,11 @@ class ReactorModuleConvergenceTest {
         // intentionally no assertTrue() cause we expect getting an exception.
     }
 
+    @Test
+    void cacheIdShouldBeSet() {
+        assertThat(rule.getCacheId()).isNotEmpty();
+    }
+
     /**
      * This small setup is equivalent to the following situation:
      *