You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Bhathiya <no...@github.com> on 2015/03/25 10:23:03 UTC
[jclouds-labs] JCLOUDS-664: Alternate Compute Service Adapter (#157)
Current mapping of Deployment to Node is the assumption that deployment always consist of single roleinststace.
1 - Introduce VirtualMachine in domain
2 - Map DeploymentToVirtualMachines where single deployment produces list of virtual machines
3 - Map VirtualMachineToNodeMetadata
4 - Change AzureComputeServiceAdapter<VirtualMachine, RoleSize,OSImage, Location>
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/157
-- Commit Summary --
* JCLOUDS-853: Improve Create VirtualMachine Deployment
* Introduce VirtualMachine
* Get Cloud Service Properties Operation Support
* NewComputeServiceAdapter
* Added Url to Deployement
* Support different names for CloudServices and Deployments
-- File Changes --
M azurecompute/src/main/java/org/jclouds/azurecompute/binders/DeploymentParamsToXML.java (269)
M azurecompute/src/main/java/org/jclouds/azurecompute/binders/RoleToXML.java (5)
M azurecompute/src/main/java/org/jclouds/azurecompute/compute/AzureComputeServiceAdapter.java (674)
M azurecompute/src/main/java/org/jclouds/azurecompute/compute/config/AzureComputeServiceContextModule.java (19)
D azurecompute/src/main/java/org/jclouds/azurecompute/compute/functions/DeploymentToNodeMetadata.java (127)
A azurecompute/src/main/java/org/jclouds/azurecompute/compute/functions/VirtualMachineToNodeMetadata.java (113)
A azurecompute/src/main/java/org/jclouds/azurecompute/domain/CloudServiceProperties.java (96)
A azurecompute/src/main/java/org/jclouds/azurecompute/domain/DataVirtualHardDiskParam.java (161)
M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Deployment.java (10)
M azurecompute/src/main/java/org/jclouds/azurecompute/domain/DeploymentParams.java (175)
A azurecompute/src/main/java/org/jclouds/azurecompute/domain/LinuxConfigurationSetParams.java (141)
A azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSVirtualHardDiskParam.java (180)
A azurecompute/src/main/java/org/jclouds/azurecompute/domain/RoleParam.java (199)
A azurecompute/src/main/java/org/jclouds/azurecompute/domain/VirtualMachine.java (218)
A azurecompute/src/main/java/org/jclouds/azurecompute/domain/WindowsConfigurationSetParams.java (153)
M azurecompute/src/main/java/org/jclouds/azurecompute/features/CloudServiceApi.java (26)
M azurecompute/src/main/java/org/jclouds/azurecompute/features/VirtualMachineApi.java (10)
A azurecompute/src/main/java/org/jclouds/azurecompute/functions/DeploymentToVirtualMachine.java (69)
M azurecompute/src/main/java/org/jclouds/azurecompute/options/AzureComputeTemplateOptions.java (20)
A azurecompute/src/main/java/org/jclouds/azurecompute/xml/CloudServicePropertiesHandler.java (155)
M azurecompute/src/main/java/org/jclouds/azurecompute/xml/DeploymentHandler.java (10)
M azurecompute/src/test/java/org/jclouds/azurecompute/compute/AzureComputeServiceAdapterLiveTest.java (28)
M azurecompute/src/test/java/org/jclouds/azurecompute/compute/AzureComputeServiceContextLiveTest.java (13)
M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiLiveTest.java (80)
M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiMockTest.java (83)
M azurecompute/src/test/java/org/jclouds/azurecompute/features/VirtualMachineApiLiveTest.java (120)
A azurecompute/src/test/java/org/jclouds/azurecompute/functions/DeploymentToVirtualMachineTest.java (49)
M azurecompute/src/test/java/org/jclouds/azurecompute/internal/BaseAzureComputeApiLiveTest.java (9)
A azurecompute/src/test/java/org/jclouds/azurecompute/xml/CloudServicePropertiesHandlerTest.java (147)
M azurecompute/src/test/java/org/jclouds/azurecompute/xml/DeploymentHandlerTest.java (1)
A azurecompute/src/test/resources/cloudserviceproperties.xml (120)
A azurecompute/src/test/resources/newdeploymentparams-linux.xml (1)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/157.patch
https://github.com/jclouds/jclouds-labs/pull/157.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/157
Re: [jclouds-labs] JCLOUDS-664: Alternate Compute Service Adapter
(#157)
Posted by Imesh Guaratne <no...@github.com>.
> + RoleSize.Type roleSize = roleParam.roleSize();
> + if (roleSize != null) {
> + roleBuilder.e("RoleSize").t(roleSize.getText()).up();
> + }
> + // add(builder, "AvailabilitySetName", params.availabilitySetName);
> + Boolean agent = roleParam.provisionGuestAgent();
> + if (agent != null) {
> + roleBuilder.e("ProvisionGuestAgent").t(agent.toString()).up();
> + }
> +
> + }
> + roleBuilder.up(); // role
> + }
> + roleListBuilder.up(); // RoleList
> + add(builder, "VirtualNetworkName", params.virtualNetworkName());
> + builder.up();
> // TODO: Undeprecate this method as forcing users to wrap a String in guava's ByteSource is not great.
> return (R) request.toBuilder().payload(builder.asString()).build();
> } catch (Exception e) {
It might be better to add a meaningful message inside the catch block when propagating an exception. Otherwise it would be difficult for users to understand which functionality did not work when an exception is raised.
Thanks
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/157/files#r27139966
Re: [jclouds-labs] JCLOUDS-664: Alternate Compute Service Adapter
(#157)
Posted by Francesco Chicchiriccò <no...@github.com>.
@hsbhathiya fine, let's proceed this way, then. Looking forward to have all your changes onboard!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/157#issuecomment-94653508
Re: [jclouds/jclouds-labs] JCLOUDS-664: Alternate Compute Service
Adapter (#157)
Posted by Andrew Gaul <no...@github.com>.
Closed #157.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/157#event-699641544
Re: [jclouds/jclouds-labs] JCLOUDS-664: Alternate Compute Service
Adapter (#157)
Posted by Ignasi Barrera <no...@github.com>.
I think hre is little hope for this PR and the ones it depends on to progress, so given that the ARM provider is getting a lot of love and will be ready soon, I think we can close these ones.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/157#issuecomment-226873060
Re: [jclouds/jclouds-labs] JCLOUDS-664: Alternate Compute Service
Adapter (#157)
Posted by Andrew Gaul <no...@github.com>.
Should we close this given the work in #279?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/157#issuecomment-226643613
Re: [jclouds-labs] JCLOUDS-664: Alternate Compute Service Adapter
(#157)
Posted by Francesco Chicchiriccò <no...@github.com>.
Hi @hsbhathiya, could you rebase this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/157#issuecomment-94409434
Re: [jclouds-labs] JCLOUDS-664: Alternate Compute Service Adapter
(#157)
Posted by Imesh Guaratne <no...@github.com>.
> + credentialsBuilder.up();
> + add(configBuilder, "JoinDomain", domainJoin.joinDomain());
> + configBuilder.e("JoinDomain").t(winParams.domainJoin().joinDomain()).up()
> + .up(); // Domain Join
> + }
> + configBuilder.e("StoredCertificateSettings").up()
> + .up(); // Windows ConfigurationSet
> + } else if (roleParam.OSVirtualHardDiskParam().OS() == OSImage.Type.LINUX) {
> + LinuxConfigurationSetParams linuxParams = roleParam.linuxConfigurationSet();
> + XMLBuilder configBuilder = configSetsBuilder.e("ConfigurationSet")
> + .a("i:type", "LinuxProvisioningConfigurationSet"); // Linux
> + configBuilder.e("ConfigurationSetType").t("LinuxProvisioningConfiguration").up();
> + add(configBuilder, "HostName", linuxParams.hostName());
> + add(configBuilder, "UserName", linuxParams.userName());
> + add(configBuilder, "UserPassword", linuxParams.userPassword());
> + configBuilder.e("DisableSshPasswordAuthentication").t("false").up()
Wouldn't it better to use constants for defining these strings?
Thanks
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/157/files#r27139626
Re: [jclouds-labs] JCLOUDS-664: Alternate Compute Service Adapter
(#157)
Posted by Bhathiya <no...@github.com>.
@ilgrosso
No had some issues with rebasing https://github.com/jclouds/jclouds-labs/pull/154. Shall we merge those it first and then come to this ?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/157#issuecomment-94526094