[GitHub] [hive] ayushtkn commented on a diff in pull request #3498: HIVE-24483: Bump protobuf version to 3.7.1 (aarch64 support).

[GitBox <gi...@apache.org>]

ayushtkn commented on code in PR #3498:
URL: https://github.com/apache/hive/pull/3498#discussion_r938747643


##########
data/files/datasets/src_hbase/load.hive.sql:
##########
@@ -1,3 +1,5 @@
+DROP table if exists src_hbase_tmp;

Review Comment:
   Yeps, I am not sure, but my test failed once and in the next iteration when I fixed it, It started giving me AlreadyExist exception for the table.
   So, I added this. It doesn't occur on successive run when the test passes. I thought better to have this. I can try removing it, If you feel so



##########
hbase-handler/src/java/org/apache/hadoop/hive/hbase/ResultWritable.java:
##########
@@ -26,8 +26,8 @@
 import org.apache.hadoop.hbase.KeyValue;
 import org.apache.hadoop.hbase.KeyValueUtil;
 import org.apache.hadoop.hbase.client.Result;
-import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
-import org.apache.hadoop.hbase.protobuf.generated.ClientProtos;
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;

Review Comment:
   The Hbase tests were failing because they had one protobuf 2.5.0 reference for some use case. So bugged the HBase folks and got that as a solution.
   https://issues.apache.org/jira/browse/HBASE-21587?focusedCommentId=17575116&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17575116



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org