You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by techaddict <gi...@git.apache.org> on 2016/05/09 22:30:18 UTC
[GitHub] spark pull request: [SPARK-15234][SQL] spark.catalog.listDatabases...
GitHub user techaddict opened a pull request:
https://github.com/apache/spark/pull/13014
[SPARK-15234][SQL] spark.catalog.listDatabases.show() is not formatted correctly
## What changes were proposed in this pull request?
Make `Database`, `Table`, `Column`, `Function` classes, case classes so that `listDatabases`, `listTables`, `listFunctions` and `listColumns` are formatted properly.
Before:
```
scala> spark.catalog.listDatabases.show()
+--------------------+-----------+-----------+
| name|description|locationUri|
+--------------------+-----------+-----------+
|Database[name='de...|
+--------------------+-----------+-----------+
```
After the Change:
```
scala> spark.catalog.listDatabases.show()
+-------+----------------+--------------------+
| name| description| locationUri|
+-------+----------------+--------------------+
|default|default database|file:/Users/pichu...|
+-------+----------------+--------------------+
```
## How was this patch tested?
Existing Tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/techaddict/spark SPARK-15234
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13014.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13014
----
commit 67730ff792b8e5a7ad1186992132abc4ac639958
Author: Sandeep Singh <sa...@techaddict.me>
Date: 2016-05-09T22:26:35Z
[SPARK-15234][SQL] spark.catalog.listDatabases.show() is not formatted correctly
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15234][SQL] spark.catalog.listDatabases...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13014#issuecomment-218015446
case classes extend `Product`, which has a bunch of methods that compile based on the existing set of fields. Even if you add a field in the future you'll break compatibility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15234][SQL] spark.catalog.listDatabases...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13014#issuecomment-218023831
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15234][SQL] spark.catalog.listDatabases...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13014#issuecomment-218009734
**[Test build #58176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58176/consoleFull)** for PR 13014 at commit [`67730ff`](https://github.com/apache/spark/commit/67730ff792b8e5a7ad1186992132abc4ac639958).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15234][SQL] spark.catalog.listDatabases...
Posted by techaddict <gi...@git.apache.org>.
Github user techaddict commented on the pull request:
https://github.com/apache/spark/pull/13014#issuecomment-218014291
My bad closed the PR. Just curious why are case classes harder to maintain ?
On Tue, May 10, 2016 at 4:23 AM, andrewor14 <no...@github.com>
wrote:
> @techaddict <https://github.com/techaddict> we don't want to make these
> classes case classes because those are harder to maintain. See the
> comment at the top of the file.
>
> Please close this PR.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/13014#issuecomment-218013348>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15234][SQL] spark.catalog.listDatabases...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13014#issuecomment-218023638
**[Test build #58176 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58176/consoleFull)** for PR 13014 at commit [`67730ff`](https://github.com/apache/spark/commit/67730ff792b8e5a7ad1186992132abc4ac639958).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class Database(`
* `case class Table(`
* `case class Column(`
* `case class Function(`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15234][SQL] spark.catalog.listDatabases...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13014#issuecomment-218023833
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58176/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15234][SQL] spark.catalog.listDatabases...
Posted by techaddict <gi...@git.apache.org>.
Github user techaddict closed the pull request at:
https://github.com/apache/spark/pull/13014
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15234][SQL] spark.catalog.listDatabases...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13014#issuecomment-218013348
@techaddict we don't want to make these classes `case classes` because those are harder to maintain. See the comment at the top of the file.
Please close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org