You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by markap14 <gi...@git.apache.org> on 2017/09/22 15:08:47 UTC
[GitHub] nifi pull request #2169: NIFI-4409: Ensure that when record schema is inheri...
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2169
NIFI-4409: Ensure that when record schema is inherited, the schema fr…
…om teh ResultSet is used instead of the schema from the RecordReader because the schema from the RecordReader mmay not match the actual data
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4409
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2169.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2169
----
commit c6a89c1c068038f2740cf4b2ad4a42983bbf7480
Author: Mark Payne <ma...@hotmail.com>
Date: 2017-09-22T15:08:22Z
NIFI-4409: Ensure that when record schema is inherited, the schema from teh ResultSet is used instead of the schema from the RecordReader because the schema from the RecordReader mmay not match the actual data
----
---
[GitHub] nifi pull request #2169: NIFI-4409: Ensure that when record schema is inheri...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2169
---
[GitHub] nifi issue #2169: NIFI-4409: Ensure that when record schema is inherited, th...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2169
Reviewing...
---
[GitHub] nifi issue #2169: NIFI-4409: Ensure that when record schema is inherited, th...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2169
+1 LGTM, built and ran unit tests, and tried two queries with different result sets, verified the different schemas and values were output correctly. Thanks for the improvement! Merging to master
---