[GitHub] [airflow] dstandish commented on a diff in pull request #23658: Fix k8s pod.execute randomly stuck indefinitely by logs consumption (#23497)

[GitBox <gi...@apache.org>]

dstandish commented on code in PR #23658:
URL: https://github.com/apache/airflow/pull/23658#discussion_r890420936


##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -256,7 +293,7 @@ def consume_logs(*, since_time: Optional[DateTime] = None, follow: bool = True)
                 time.sleep(1)
 
     def await_container_completion(self, pod: V1Pod, container_name: str) -> None:
-        while not self.container_is_running(pod=pod, container_name=container_name):
+        while self.container_is_running(pod=pod, container_name=container_name):

Review Comment:
   this looks like it is unrelated to your main change.  could you please raise a separatae PR for this change specifically?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org