You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Norris Lee <no...@simba.com> on 2015/01/06 01:10:12 UTC
Re: Review Request 26672: DRILL-1533 C++ Drill Client always sets
hasSchemaChanged to true for every new record batch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26672/
-----------------------------------------------------------
(Updated Jan. 6, 2015, 12:10 a.m.)
Review request for drill and Parth Chandra.
Changes
-------
Rebase to head, squashed commits
Repository: drill-git
Description
-------
hasSchemaChanged is always set as true for all record batches except the first one regardless of whether the schema has changed or not, including cases where specific columns are projected, which should never happen.
Diffs (updated)
-----
contrib/native/client/src/clientlib/drillClientImpl.cpp 23dc407
Diff: https://reviews.apache.org/r/26672/diff/
Testing
-------
Thanks,
Norris Lee
Re: Review Request 26672: DRILL-1533 C++ Drill Client always sets
hasSchemaChanged to true for every new record batch
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26672/#review67090
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On Jan. 6, 2015, 12:10 a.m., Norris Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26672/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 12:10 a.m.)
>
>
> Review request for drill and Parth Chandra.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> hasSchemaChanged is always set as true for all record batches except the first one regardless of whether the schema has changed or not, including cases where specific columns are projected, which should never happen.
>
>
> Diffs
> -----
>
> contrib/native/client/src/clientlib/drillClientImpl.cpp 23dc407
>
> Diff: https://reviews.apache.org/r/26672/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Norris Lee
>
>