[jira] Commented: (DIRMINA-527) should be able to set connect timeout in milliseconds

["Niklas Therning (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566465#action_12566465 ] 

Niklas Therning commented on DIRMINA-527:
-----------------------------------------

The API for 1.0/1.1 has been frozen. Since this patch introduces changes in the API it should only go into trunk. Please, anyone, correct me if I'm wrong.

BTW, the patch looks great! One tiny detail, I think the coding conventions we're using in MINA mandates spaces around operators. E.g. 60*1000L => 60 * 1000L. See http://mina.apache.org/developer-guide.html#DeveloperGuide-CodingConvention for more info.

> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
>                 Key: DIRMINA-527
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-527
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
>            Reporter: Sangjin Lee
>         Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds.  The minimum value of allowed connect timeout is 1 second.  There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.