[jira] [Commented] (SSHD-149) Is separation of sftp subsystem interfaces possible?

["Guillaume Nodet (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SSHD-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546750#comment-13546750 ] 

Guillaume Nodet commented on SSHD-149:
--------------------------------------

Sorry about the very long delay.
I've had a look at your proposal and it overall looks good to me but needs to be cleaned up.
Could you please provide a reworked patch with
  * changing the proposal package to org.apache.sshd.sftp
  * adding the ASF headers to new files
  * adding the getId() directly to the serverSession
  * removing all duplicate code caused by the added object model: if we introduce an object model, we should be able to use it to process the commands instead of re-reading the whole command and processing it from the byte buffer
  * I think we should have the response being created in the SftpSubsystem#process() method and have a single location at the end of this method where the reply is processed by the ftplet before being sent
  * we don't use fieldXxx convention in the code, so please adapt to the current convention and use this.id = id instead of fieldId = id
  * please use @author <a href="http://mina.apache.org">Apache MINA Project</a> instead of your name, i'll add your name as a contributor to the project instead
  * please provide the patch as a diff file so that no modifications are lost (i've done some recently compared to your patch)

Anyway, sorry again for the delay.  The idea is really good, the patch just needs a bit more work.  

                
> Is separation of sftp subsystem interfaces possible?
> ----------------------------------------------------
>
>                 Key: SSHD-149
>                 URL: https://issues.apache.org/jira/browse/SSHD-149
>             Project: MINA SSHD
>          Issue Type: Question
>            Reporter: Stefan Rönisch
>         Attachments: sftp.tar.gz
>
>
> We'd like to use the mina sshd sftp funtionallity.
> I've to validate, if this product fits our needs.
> As far as I saw until now it looks great.
> But we've to support some special requirements.
> - We have to support a special proxy solution for dmz which handles ssh encryption and authentication. So we need to use the sftpsubsystem without ssh encryption. Unfortunately, there are some method signatures which avoid this.
> - We have to manipulate sftp command results in some cases. For example we like trigger internal processes after getting a file, but if triggering the process fails the sftp command result should signal an error.
> Is there a chance that our needs will be considered?
> And when a solution could be expected?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira