You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Kevin Ballard (JIRA)" <ji...@apache.org> on 2010/07/17 06:03:49 UTC
[jira] Created: (THRIFT-821) TMemoryBuffer needs a way to access
the buffer
TMemoryBuffer needs a way to access the buffer
----------------------------------------------
Key: THRIFT-821
URL: https://issues.apache.org/jira/browse/THRIFT-821
Project: Thrift
Issue Type: Improvement
Components: Library (Cocoa)
Reporter: Kevin Ballard
TMemoryBuffer in Cocoa provides no way to access the buffer. This makes it unusable for converting a thrift object into data, for use with an alternate transport mechanism.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-821) TMemoryBuffer needs a way to access
the buffer
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned THRIFT-821:
------------------------------------
Assignee: Kevin Ballard
> TMemoryBuffer needs a way to access the buffer
> ----------------------------------------------
>
> Key: THRIFT-821
> URL: https://issues.apache.org/jira/browse/THRIFT-821
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Cocoa)
> Reporter: Kevin Ballard
> Assignee: Kevin Ballard
> Attachments: TMemoryBuffer.patch
>
>
> TMemoryBuffer in Cocoa provides no way to access the buffer. This makes it unusable for converting a thrift object into data, for use with an alternate transport mechanism.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-821) TMemoryBuffer needs a way to access
the buffer
Posted by "Kevin Ballard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890842#action_12890842 ]
Kevin Ballard commented on THRIFT-821:
--------------------------------------
Naming it 'buffer' might imply that it's direct access to the underlying buffer. What the method actually does is provide a snapshot of the buffer. If you want to name it 'buffer', go ahead, I just wanted to avoid any confusion.
> TMemoryBuffer needs a way to access the buffer
> ----------------------------------------------
>
> Key: THRIFT-821
> URL: https://issues.apache.org/jira/browse/THRIFT-821
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Cocoa)
> Reporter: Kevin Ballard
> Attachments: TMemoryBuffer.patch
>
>
> TMemoryBuffer in Cocoa provides no way to access the buffer. This makes it unusable for converting a thrift object into data, for use with an alternate transport mechanism.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-821) TMemoryBuffer needs a way to access
the buffer
Posted by "Andrew McGeachie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew McGeachie resolved THRIFT-821.
-------------------------------------
Resolution: Fixed
Patch applied.
> TMemoryBuffer needs a way to access the buffer
> ----------------------------------------------
>
> Key: THRIFT-821
> URL: https://issues.apache.org/jira/browse/THRIFT-821
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Cocoa)
> Reporter: Kevin Ballard
> Attachments: TMemoryBuffer.patch
>
>
> TMemoryBuffer in Cocoa provides no way to access the buffer. This makes it unusable for converting a thrift object into data, for use with an alternate transport mechanism.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-821) TMemoryBuffer needs a way to access
the buffer
Posted by "Andrew McGeachie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890837#action_12890837 ]
Andrew McGeachie commented on THRIFT-821:
-----------------------------------------
I propose naming the new method:
- (NSData *) buffer;
rather than 'getBuffer' since the Cocoa convention is not to prefix getters with 'get' (don't ask me *why* that's the convention...).
Thoughts?
> TMemoryBuffer needs a way to access the buffer
> ----------------------------------------------
>
> Key: THRIFT-821
> URL: https://issues.apache.org/jira/browse/THRIFT-821
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Cocoa)
> Reporter: Kevin Ballard
> Attachments: TMemoryBuffer.patch
>
>
> TMemoryBuffer in Cocoa provides no way to access the buffer. This makes it unusable for converting a thrift object into data, for use with an alternate transport mechanism.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-821) TMemoryBuffer needs a way to access
the buffer
Posted by "Andrew McGeachie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890856#action_12890856 ]
Andrew McGeachie commented on THRIFT-821:
-----------------------------------------
I see. Makes sense. I'll apply as is.
> TMemoryBuffer needs a way to access the buffer
> ----------------------------------------------
>
> Key: THRIFT-821
> URL: https://issues.apache.org/jira/browse/THRIFT-821
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Cocoa)
> Reporter: Kevin Ballard
> Attachments: TMemoryBuffer.patch
>
>
> TMemoryBuffer in Cocoa provides no way to access the buffer. This makes it unusable for converting a thrift object into data, for use with an alternate transport mechanism.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-821) TMemoryBuffer needs a way to access
the buffer
Posted by "Kevin Ballard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Ballard updated THRIFT-821:
---------------------------------
Patch Info: [Patch Available]
> TMemoryBuffer needs a way to access the buffer
> ----------------------------------------------
>
> Key: THRIFT-821
> URL: https://issues.apache.org/jira/browse/THRIFT-821
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Cocoa)
> Reporter: Kevin Ballard
> Attachments: TMemoryBuffer.patch
>
>
> TMemoryBuffer in Cocoa provides no way to access the buffer. This makes it unusable for converting a thrift object into data, for use with an alternate transport mechanism.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-821) TMemoryBuffer needs a way to access
the buffer
Posted by "Kevin Ballard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Ballard updated THRIFT-821:
---------------------------------
Attachment: TMemoryBuffer.patch
Patch to resolve this issue
> TMemoryBuffer needs a way to access the buffer
> ----------------------------------------------
>
> Key: THRIFT-821
> URL: https://issues.apache.org/jira/browse/THRIFT-821
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Cocoa)
> Reporter: Kevin Ballard
> Attachments: TMemoryBuffer.patch
>
>
> TMemoryBuffer in Cocoa provides no way to access the buffer. This makes it unusable for converting a thrift object into data, for use with an alternate transport mechanism.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.