You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/10 08:24:01 UTC
[jira] [Commented] (WEEX-88) BOOL arguments cannot be received
correctly by component's method in 32-bit iOS devices
[ https://issues.apache.org/jira/browse/WEEX-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247185#comment-16247185 ]
ASF GitHub Bot commented on WEEX-88:
------------------------------------
GitHub user xusw opened a pull request:
https://github.com/apache/incubator-weex/pull/849
* [ios] fix #WEEX-88, support BOOL type argument bridging when in 32-…
…bit iOS and add related unit test.
https://issues.apache.org/jira/browse/WEEX-88
First of all, thank you for your contribution!
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
<!--
How to use github markdown?
### checkable example
- [x] checked
- [ ] not checked
More github Markdown info to see https://guides.github.com/features/mastering-markdown/
-->
CheckList:
**if** *isBugFix* **:**
* [x] Make sure that you add at least one unit test for the bug which you had fixed.
**elif** *isNewFeature* **:**
* [ ] Update API docs for the component.
* [ ] Update/Add demo to demonstrate new feature.
* [ ] Update test scripts for the feature.
* [ ] Add unit tests for the feature.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xusw/incubator-weex ios-bugfix-bridging-bool-arg-32-bits-OS
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/849.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #849
----
commit 815fa337e454b7782971024a5dad3dfb202cab1f
Author: xusw <xu...@gmail.com>
Date: 2017-11-10T08:15:31Z
* [ios] fix #WEEX-88, support BOOL type argument bridging when in 32-bit iOS and add related unit test.
----
> BOOL arguments cannot be received correctly by component's method in 32-bit iOS devices
> ---------------------------------------------------------------------------------------
>
> Key: WEEX-88
> URL: https://issues.apache.org/jira/browse/WEEX-88
> Project: Weex
> Issue Type: Bug
> Components: iOS
> Affects Versions: 0.15
> Environment: iPhone 4s (iOS 9.1), iPhone 5 simulator (iOS 10.3)
> Reporter: Shiwen XU
> Assignee: Adam Feng
> Priority: Blocker
>
> BOOL arguments cannot be received correctly by component's method in 32-bit iOS devices. It appears that the received argument is always some integer value other than boolean value.
> This problem might be introduced by the macro *WX_ARGUMENTS_SET*.
> {code:title=WXUtility.h|borderStyle=solid}
> #define WX_ARGUMENTS_SET(_invocation, _sig, idx, _obj, _ppFree) \
> do {\
> const char *encode = [_sig getArgumentTypeAtIndex:(idx) + 2];\
> switch(encode[0]){\
> WX_EPCHAR_CASE(_invocation, idx, _C_CHARPTR, _obj, char *, UTF8String, _ppFree)\
> WX_ENUMBER_CASE(_invocation, idx, _C_INT, _obj, int, intValue, _ppFree)\
> WX_ENUMBER_CASE(_invocation, idx, _C_SHT, _obj, short, shortValue, _ppFree)\
> WX_ENUMBER_CASE(_invocation, idx, _C_LNG, _obj, long, longValue, _ppFree)\
> WX_ENUMBER_CASE(_invocation, idx, _C_LNG_LNG, _obj, long long, longLongValue, _ppFree)\
> WX_ENUMBER_CASE(_invocation, idx, _C_UCHR, _obj, unsigned char, unsignedCharValue, _ppFree)\
> WX_ENUMBER_CASE(_invocation, idx, _C_UINT, _obj, unsigned int, unsignedIntValue, _ppFree)\
> WX_ENUMBER_CASE(_invocation, idx, _C_USHT, _obj, unsigned short, unsignedShortValue, _ppFree)\
> WX_ENUMBER_CASE(_invocation, idx, _C_ULNG, _obj, unsigned long, unsignedLongValue, _ppFree)\
> WX_ENUMBER_CASE(_invocation, idx, _C_ULNG_LNG, _obj,unsigned long long, unsignedLongLongValue, _ppFree)\
> WX_ENUMBER_CASE(_invocation, idx, _C_FLT, _obj, float, floatValue, _ppFree)\
> WX_ENUMBER_CASE(_invocation, idx, _C_DBL, _obj, double, doubleValue, _ppFree)\
> WX_ENUMBER_CASE(_invocation, idx, _C_BOOL, _obj, bool, boolValue, _ppFree)\
> default: { [_invocation setArgument:&_obj atIndex:(idx) + 2]; *(_ppFree + idx) = 0; break;}\
> }\
> }while(0)
> {code}
> The BOOL value in 32-bit iOS is a typedef of signed char so its *@encode* is *_C_CHR* instead of *_C_BOOL*. We can find the typedef in objc.h.
> {code:title=objc.h|borderStyle=solid}
> #if defined(__OBJC_BOOL_IS_BOOL)
> // Honor __OBJC_BOOL_IS_BOOL when available.
> # if __OBJC_BOOL_IS_BOOL
> # define OBJC_BOOL_IS_BOOL 1
> # else
> # define OBJC_BOOL_IS_BOOL 0
> # endif
> #else
> // __OBJC_BOOL_IS_BOOL not set.
> # if TARGET_OS_OSX || (TARGET_OS_IOS && !__LP64__ && !__ARM_ARCH_7K)
> # define OBJC_BOOL_IS_BOOL 0
> # else
> # define OBJC_BOOL_IS_BOOL 1
> # endif
> #endif
> #if OBJC_BOOL_IS_BOOL
> typedef bool BOOL;
> #else
> # define OBJC_BOOL_IS_CHAR 1
> typedef signed char BOOL;
> // BOOL is explicitly signed so @encode(BOOL) == "c" rather than "C"
> // even if -funsigned-char is used.
> #endif
> {code}
> But *WX_ARGUMENTS_SET* didn't consider the case of *_C_CHR*. In this case the default condition is executed and the *NSNumber pointer* value will be casted to a *BOOL* value so the received argument is always wrong.
> If I add this line of code and the received argument will become correct.
> {code}
> WX_ENUMBER_CASE(_invocation, idx, _C_UCHR, _obj, unsigned char, unsignedCharValue, _ppFree)\
> /* added code */
> WX_ENUMBER_CASE(_invocation, idx, _C_CHR, _obj, char, charValue, _ppFree)\
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)