You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modproxy-dev@apache.org by Ian Holsman <ia...@cnet.com> on 2001/07/14 22:36:21 UTC
Re: cvs commit: httpd-proxy/module-2.0 proxy_http.c
1st..
sorry about the blank log..
while I was playing around, I noticed that the Connection Close: header
was being merged, and not set. I'm not 100% on what is needed for
keep-alives, so I left it alone.
the other thing I noticed was that the error message passed back
could be more informative (like it could pass the error message/#
received from the proxy). I didn't patch this as I thought it might
be a security concern (leaking info about hidden boxes) I guess we could
put the r-proxy'd message in as a notice or something.
..iAn
On 14 Jul 2001 20:17:08 +0000, ianh@apache.org wrote:
> ianh 01/07/14 13:17:08
>
> Modified: module-2.0 proxy_http.c
> Log:
>
>
> Revision Changes Path
> 1.77 +3 -3 httpd-proxy/module-2.0/proxy_http.c
>
> Index: proxy_http.c
> ===================================================================
> RCS file: /home/cvs/httpd-proxy/module-2.0/proxy_http.c,v
> retrieving revision 1.76
> retrieving revision 1.77
> diff -u -r1.76 -r1.77
> --- proxy_http.c 2001/07/02 03:37:37 1.76
> +++ proxy_http.c 2001/07/14 20:17:07 1.77
> @@ -532,20 +532,20 @@
> /* Add X-Forwarded-For: so that the upstream has a chance to
> * determine, where the original request came from.
> */
> - apr_table_mergen(r->headers_in, "X-Forwarded-For", r->connection->remote_ip);
> + apr_table_setn(r->headers_in, "X-Forwarded-For", r->connection->remote_ip);
>
> /* Add X-Forwarded-Host: so that upstream knows what the
> * original request hostname was.
> */
> if ((buf = apr_table_get(r->headers_in, "Host"))) {
> - apr_table_mergen(r->headers_in, "X-Forwarded-Host", buf);
> + apr_table_setn(r->headers_in, "X-Forwarded-Host", buf);
> }
>
> /* Add X-Forwarded-Server: so that upstream knows what the
> * name of this proxy server is (if there are more than one)
> * XXX: This duplicates Via: - do we strictly need it?
> */
> - apr_table_mergen(r->headers_in, "X-Forwarded-Server",
> + apr_table_setn(r->headers_in, "X-Forwarded-Server",
> r->server->server_hostname);
> }
>
>
>
>
--
Ian Holsman
Performance Measurement & Analysis
CNET Networks - 415 364-8608
Re: cvs commit: httpd-proxy/module-2.0 proxy_http.c
Posted by Graham Leggett <mi...@sharp.fm>.
Ian Holsman wrote:
> while I was playing around, I noticed that the Connection Close: header
> was being merged, and not set. I'm not 100% on what is needed for
> keep-alives, so I left it alone.
Hmmm - I think this should be patched too. Connection: close only makes
sense for the main request, not subrequests...
> the other thing I noticed was that the error message passed back
> could be more informative (like it could pass the error message/#
> received from the proxy). I didn't patch this as I thought it might
> be a security concern (leaking info about hidden boxes) I guess we could
> put the r-proxy'd message in as a notice or something.
In theory the error message would be logged by the backend server (if I
am understanding you correctly) so it shouldn't be necessary to embed
the error message...
Regards,
Graham
--
-----------------------------------------
minfrin@sharp.fm "There's a moon
over Bourbon Street
tonight..."