You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by es...@apache.org on 2009/09/17 21:19:11 UTC

svn commit: r816340 - /incubator/thrift/trunk/compiler/cpp/src/generate/t_py_generator.cc

Author: esteve
Date: Thu Sep 17 19:19:11 2009
New Revision: 816340

URL: http://svn.apache.org/viewvc?rev=816340&view=rev
Log:
generate Twisted code in a separate directory (gen-py.twisted)

Modified:
    incubator/thrift/trunk/compiler/cpp/src/generate/t_py_generator.cc

Modified: incubator/thrift/trunk/compiler/cpp/src/generate/t_py_generator.cc
URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/compiler/cpp/src/generate/t_py_generator.cc?rev=816340&r1=816339&r2=816340&view=diff
==============================================================================
--- incubator/thrift/trunk/compiler/cpp/src/generate/t_py_generator.cc (original)
+++ incubator/thrift/trunk/compiler/cpp/src/generate/t_py_generator.cc Thu Sep 17 19:19:11 2009
@@ -52,7 +52,11 @@
     iter = parsed_options.find("twisted");
     gen_twisted_ = (iter != parsed_options.end());
 
-    out_dir_base_ = "gen-py";
+    if (gen_twisted_){
+      out_dir_base_ = "gen-py.twisted";
+    } else {
+      out_dir_base_ = "gen-py";
+    }
   }
 
   /**



Re: svn commit: r816340 - /incubator/thrift/trunk/compiler/cpp/src/generate/t_py_generator.cc

Posted by Esteve Fernandez <es...@sindominio.net>.
Hi

> Would you mind putting the bug number in your commit messages?
> It makes it easier to find the context later on.  Thanks.

Sorry, I forgot. I noticed that just after I hit enter.

Cheers.


Re: svn commit: r816340 - /incubator/thrift/trunk/compiler/cpp/src/generate/t_py_generator.cc

Posted by David Reiss <dr...@facebook.com>.
Would you mind putting the bug number in your commit messages?
It makes it easier to find the context later on.  Thanks.

--David

esteve@apache.org wrote:
> Author: esteve
> Date: Thu Sep 17 19:19:11 2009
> New Revision: 816340
> 
> URL: http://svn.apache.org/viewvc?rev=816340&view=rev
> Log:
> generate Twisted code in a separate directory (gen-py.twisted)
> 
> Modified:
>     incubator/thrift/trunk/compiler/cpp/src/generate/t_py_generator.cc
> 
> Modified: incubator/thrift/trunk/compiler/cpp/src/generate/t_py_generator.cc
> URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/compiler/cpp/src/generate/t_py_generator.cc?rev=816340&r1=816339&r2=816340&view=diff
> ==============================================================================
> --- incubator/thrift/trunk/compiler/cpp/src/generate/t_py_generator.cc (original)
> +++ incubator/thrift/trunk/compiler/cpp/src/generate/t_py_generator.cc Thu Sep 17 19:19:11 2009
> @@ -52,7 +52,11 @@
>      iter = parsed_options.find("twisted");
>      gen_twisted_ = (iter != parsed_options.end());
>  
> -    out_dir_base_ = "gen-py";
> +    if (gen_twisted_){
> +      out_dir_base_ = "gen-py.twisted";
> +    } else {
> +      out_dir_base_ = "gen-py";
> +    }
>    }
>  
>    /**
> 
>