[GitHub] [ozone] ChenSammi commented on a diff in pull request #5160: HDDS-8011. IllegalArgumentException logged for invalid user-defined metadata

["ChenSammi (via GitHub)" <gi...@apache.org>]

ChenSammi commented on code in PR #5160:
URL: https://github.com/apache/ozone/pull/5160#discussion_r1295642956


##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/exception/S3ErrorTable.java:
##########
@@ -126,6 +126,11 @@ private S3ErrorTable() {
   public static final OS3Exception NO_OVERWRITE = new OS3Exception(
       "Conflict", "Cannot overwrite file with directory", HTTP_CONFLICT);
 
+  public static final OS3Exception METADATA_TOO_LARGE = new OS3Exception(
+      "MetadataTooLarge", "Illegal user defined metadata. Combined size " +
+      "exceeds the maximum allowed metadata size of 2KB",

Review Comment:
   Please use S3_REQUEST_HEADER_METADATA_SIZE_LIMIT_KB instead of 2KB here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org