You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/10/06 03:23:27 UTC
[PR] GH-38063: [C++] Use absolute path for external project's ar/ranlib [arrow]
kou opened a new pull request, #38064:
URL: https://github.com/apache/arrow/pull/38064
### Rationale for this change
If we use relative path, CMake try using relative path from a build directory.
### What changes are included in this PR?
Ensure using absolute path.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38063: [C++] Use absolute path for external project's ar/ranlib [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #38064:
URL: https://github.com/apache/arrow/pull/38064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38063: [C++] Use absolute path for external project's ar/ranlib [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38064:
URL: https://github.com/apache/arrow/pull/38064#issuecomment-1756664898
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 34eb21df5aa5799bf5ecca42a0542ae0124a439e.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/17587419947) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38063: [C++] Use absolute path for external project's ar/ranlib [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38064:
URL: https://github.com/apache/arrow/pull/38064#issuecomment-1749932569
:warning: GitHub issue #38063 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38063: [C++] Use absolute path for external project's ar/ranlib [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38064:
URL: https://github.com/apache/arrow/pull/38064#issuecomment-1753730015
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org