You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/12/29 21:57:56 UTC

[GitHub] [netbeans] lkishalmi commented on a change in pull request #1829: [NETBEANS-3648] Support single quotes in parameter parsing

lkishalmi commented on a change in pull request #1829: [NETBEANS-3648] Support single quotes in parameter parsing
URL: https://github.com/apache/netbeans/pull/1829#discussion_r361874549
 
 

 ##########
 File path: platform/openide.util/src/org/openide/util/BaseUtilities.java
 ##########
 @@ -1036,12 +1036,11 @@ public static Object toPrimitiveArray(Object[] array) {
     * @return an array of parameters
     */
     public static String[] parseParameters(String s) {
-        int NULL = 0x0; // STICK + whitespace or NULL + non_"
-        int INPARAM = 0x1; // NULL + " or STICK + " or INPARAMPENDING + "\ // NOI18N
-        int INPARAMPENDING = 0x2; // INPARAM + \
-        int STICK = 0x4; // INPARAM + " or STICK + non_" // NOI18N
-        int STICKPENDING = 0x8; // STICK + \
-        ArrayList<String> params = new ArrayList<String>(5);
+        final int NULL = 0x0; // STICK + whitespace or NULL + non_"
+        final int IN_PARAM = 0x1; // NULL + " or STICK + " or INPARAMPENDING + "\ // NOI18N
 
 Review comment:
   That's true, I've spent some time to figure out what would the STICK and others mean in the original parser. Removed it for good.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists