[jira] [Comment Edited] (TS-1801) Remove proxy.config.net.throttle_enabled

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623290#comment-13623290 ] 

Leif Hedstrom edited comment on TS-1801 at 4/5/13 3:15 AM:
-----------------------------------------------------------

This is not about nuking throttle control. In fact, it's the complete opposite. This option was added for a specific Yahoo debug case, and should never have been left in there. It blindly turns off throttle control, and lets the server get into a non-deterministic state (best case scenario, erroring out big time when it runs out of FDs).
                
      was (Author: zwoop):
    This is not about nuking throttle control. In fact, it's the complete opposite. This option was added for a specific Yahoo debug case, and should never have been left in there. It blindly turns off throttle control, and lets the server get into a deterministic state (best case scenario, erroring out big time when it runs out of FDs).
                  
> Remove proxy.config.net.throttle_enabled
> ----------------------------------------
>
>                 Key: TS-1801
>                 URL: https://issues.apache.org/jira/browse/TS-1801
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Network
>            Reporter: Leif Hedstrom
>            Assignee: Leif Hedstrom
>             Fix For: 3.3.2
>
>
> This setting is fairly nonsensical, and, it seems it was added a while ago when we had issues with leaking FDs and/or stats:
> {code}
> TS_INLINE int
> check_net_throttle(ThrottleType t, ink_hrtime now)
> {
>   if(throttle_enabled == false) {
>     // added by Vijay to disable throttle. This is done find out if
>     // there any other problem other than the stats problem -- bug 3040824
>     return false;
>   }
> {code}
> This setting just makes no sense, because we really honor proxy.config.net.connections_throttle, which also controls the amount of FDs we setrlimit() on.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira