You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Sebastian Toader <st...@hortonworks.com> on 2016/02/26 11:48:39 UTC

Review Request 44064: Unusable configs after creating override

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44064/
-----------------------------------------------------------

Review request for Ambari, Daniel Gergely, Robert Levas, and Robert Nettleton.


Bugs: AMBARI-15200
    https://issues.apache.org/jira/browse/AMBARI-15200


Repository: ambari


Description
-------

Ambari server keeps all versions of service configurations. When the UI requests all service configution versions for a service it expects in the response an additional flag that marks which ones are the active ones. Since this active flag is not stored in the database the server works out this flag on demand based on the create time stamp, version of the service config entity.

As part of AMBARI-15158 a bug has been introduce as it was assumed that there is only one "current" service configuration version per service accross each service configuration group.
This is wrong assumption as there is always ine "current" service configuration version per each configuration group for a service.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 4faee0e 
  ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 4d8e13b 

Diff: https://reviews.apache.org/r/44064/diff/


Testing
-------

Manual testing: created 3 node cluster and tested the fix with multiple config groups and service configs.

All ambari server unit tests completed fine (branch-2.2 and 2.2.1-main; unit tests on trunk currently  running)


Thanks,

Sebastian Toader

Re: Review Request 44064: Unusable configs after creating override

Posted by Robert Levas <rl...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44064/#review120878
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Levas


On Feb. 26, 2016, 7:29 a.m., Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44064/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 7:29 a.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Robert Levas, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-15200
>     https://issues.apache.org/jira/browse/AMBARI-15200
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari server keeps all versions of service configurations. When the UI requests all service configution versions for a service it expects in the response an additional flag that marks which ones are the active ones. Since this active flag is not stored in the database the server works out this flag on demand based on the create time stamp, version of the service config entity.
> 
> As part of AMBARI-15158 a bug has been introduce as it was assumed that there is only one "current" service configuration version per service accross each service configuration group.
> This is wrong assumption as there is always ine "current" service configuration version per each configuration group for a service.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 4faee0e 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 4d8e13b 
> 
> Diff: https://reviews.apache.org/r/44064/diff/
> 
> 
> Testing
> -------
> 
> Manual testing: created 3 node cluster and tested the fix with multiple config groups and service configs.
> 
> All ambari server unit tests completed fine (branch-2.2 and 2.2.1-main; trunk)
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 44064: Unusable configs after creating override

Posted by Robert Nettleton <rn...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44064/#review120875
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Nettleton


On Feb. 26, 2016, 12:29 p.m., Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44064/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 12:29 p.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Robert Levas, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-15200
>     https://issues.apache.org/jira/browse/AMBARI-15200
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari server keeps all versions of service configurations. When the UI requests all service configution versions for a service it expects in the response an additional flag that marks which ones are the active ones. Since this active flag is not stored in the database the server works out this flag on demand based on the create time stamp, version of the service config entity.
> 
> As part of AMBARI-15158 a bug has been introduce as it was assumed that there is only one "current" service configuration version per service accross each service configuration group.
> This is wrong assumption as there is always ine "current" service configuration version per each configuration group for a service.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 4faee0e 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 4d8e13b 
> 
> Diff: https://reviews.apache.org/r/44064/diff/
> 
> 
> Testing
> -------
> 
> Manual testing: created 3 node cluster and tested the fix with multiple config groups and service configs.
> 
> All ambari server unit tests completed fine (branch-2.2 and 2.2.1-main; trunk)
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 44064: Unusable configs after creating override

Posted by Daniel Gergely <dg...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44064/#review120867
-----------------------------------------------------------


Ship it!




Ship It!

- Daniel Gergely


On febr. 26, 2016, 12:29 du, Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44064/
> -----------------------------------------------------------
> 
> (Updated febr. 26, 2016, 12:29 du)
> 
> 
> Review request for Ambari, Daniel Gergely, Robert Levas, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-15200
>     https://issues.apache.org/jira/browse/AMBARI-15200
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari server keeps all versions of service configurations. When the UI requests all service configution versions for a service it expects in the response an additional flag that marks which ones are the active ones. Since this active flag is not stored in the database the server works out this flag on demand based on the create time stamp, version of the service config entity.
> 
> As part of AMBARI-15158 a bug has been introduce as it was assumed that there is only one "current" service configuration version per service accross each service configuration group.
> This is wrong assumption as there is always ine "current" service configuration version per each configuration group for a service.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 4faee0e 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 4d8e13b 
> 
> Diff: https://reviews.apache.org/r/44064/diff/
> 
> 
> Testing
> -------
> 
> Manual testing: created 3 node cluster and tested the fix with multiple config groups and service configs.
> 
> All ambari server unit tests completed fine (branch-2.2 and 2.2.1-main; trunk)
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 44064: Unusable configs after creating override

Posted by Mahadev Konar <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44064/#review120873
-----------------------------------------------------------


Ship it!




Ship It!

- Mahadev Konar


On Feb. 26, 2016, 12:29 p.m., Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44064/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 12:29 p.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Robert Levas, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-15200
>     https://issues.apache.org/jira/browse/AMBARI-15200
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari server keeps all versions of service configurations. When the UI requests all service configution versions for a service it expects in the response an additional flag that marks which ones are the active ones. Since this active flag is not stored in the database the server works out this flag on demand based on the create time stamp, version of the service config entity.
> 
> As part of AMBARI-15158 a bug has been introduce as it was assumed that there is only one "current" service configuration version per service accross each service configuration group.
> This is wrong assumption as there is always ine "current" service configuration version per each configuration group for a service.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 4faee0e 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 4d8e13b 
> 
> Diff: https://reviews.apache.org/r/44064/diff/
> 
> 
> Testing
> -------
> 
> Manual testing: created 3 node cluster and tested the fix with multiple config groups and service configs.
> 
> All ambari server unit tests completed fine (branch-2.2 and 2.2.1-main; trunk)
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 44064: Unusable configs after creating override

Posted by Alejandro Fernandez <af...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44064/#review120921
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java (line 1365)
<https://reviews.apache.org/r/44064/#comment182449>

    If this test is ever changed, would be good to assert that all three versions were found and asserted, can use a counter and assert that counter == 3
    Please use braces for if-else blocks



ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java (line 1380)
<https://reviews.apache.org/r/44064/#comment182447>

    This statement is not needed.


- Alejandro Fernandez


On Feb. 26, 2016, 12:29 p.m., Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44064/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 12:29 p.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Robert Levas, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-15200
>     https://issues.apache.org/jira/browse/AMBARI-15200
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari server keeps all versions of service configurations. When the UI requests all service configution versions for a service it expects in the response an additional flag that marks which ones are the active ones. Since this active flag is not stored in the database the server works out this flag on demand based on the create time stamp, version of the service config entity.
> 
> As part of AMBARI-15158 a bug has been introduce as it was assumed that there is only one "current" service configuration version per service accross each service configuration group.
> This is wrong assumption as there is always ine "current" service configuration version per each configuration group for a service.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 4faee0e 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 4d8e13b 
> 
> Diff: https://reviews.apache.org/r/44064/diff/
> 
> 
> Testing
> -------
> 
> Manual testing: created 3 node cluster and tested the fix with multiple config groups and service configs.
> 
> All ambari server unit tests completed fine (branch-2.2 and 2.2.1-main; trunk)
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 44064: Unusable configs after creating override

Posted by Sid Wagle <sw...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44064/#review121126
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On Feb. 27, 2016, 10:16 p.m., Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44064/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2016, 10:16 p.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Robert Levas, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-15200
>     https://issues.apache.org/jira/browse/AMBARI-15200
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari server keeps all versions of service configurations. When the UI requests all service configution versions for a service it expects in the response an additional flag that marks which ones are the active ones. Since this active flag is not stored in the database the server works out this flag on demand based on the create time stamp, version of the service config entity.
> 
> As part of AMBARI-15158 a bug has been introduce as it was assumed that there is only one "current" service configuration version per service accross each service configuration group.
> This is wrong assumption as there is always ine "current" service configuration version per each configuration group for a service.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionResponse.java c02bb6e 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 4faee0e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/ServiceConfigVersionResponseTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 4d8e13b 
> 
> Diff: https://reviews.apache.org/r/44064/diff/
> 
> 
> Testing
> -------
> 
> Manual testing: created 3 node cluster and tested the fix with multiple config groups and service configs.
> 
> All ambari server unit tests completed fine (branch-2.2 and 2.2.1-main; trunk)
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 44064: Unusable configs after creating override

Posted by Sebastian Toader <st...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44064/
-----------------------------------------------------------

(Updated Feb. 27, 2016, 11:16 p.m.)

Review request for Ambari, Daniel Gergely, Robert Levas, and Robert Nettleton.

Changes
-------

Fixed issued listed by reviewers.

Bugs: AMBARI-15200
https://issues.apache.org/jira/browse/AMBARI-15200

Repository: ambari

Description
-------

Ambari server keeps all versions of service configurations. When the UI requests all service configution versions for a service it expects in the response an additional flag that marks which ones are the active ones. Since this active flag is not stored in the database the server works out this flag on demand based on the create time stamp, version of the service config entity.

As part of AMBARI-15158 a bug has been introduce as it was assumed that there is only one "current" service configuration version per service accross each service configuration group.
This is wrong assumption as there is always ine "current" service configuration version per each configuration group for a service.

Diffs (updated)
-----

ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionResponse.java c02bb6e
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 4faee0e
ambari-server/src/test/java/org/apache/ambari/server/controller/ServiceConfigVersionResponseTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 4d8e13b

Diff: https://reviews.apache.org/r/44064/diff/

Testing
-------

Manual testing: created 3 node cluster and tested the fix with multiple config groups and service configs.

All ambari server unit tests completed fine (branch-2.2 and 2.2.1-main; trunk)

Thanks,

Sebastian Toader

Re: Review Request 44064: Unusable configs after creating override

Posted by Sebastian Toader <st...@hortonworks.com>.

(Updated Feb. 26, 2016, 1:29 p.m.)

Review request for Ambari, Daniel Gergely, Robert Levas, and Robert Nettleton.

Changes
-------

Unit test passed on trunk as well

Bugs: AMBARI-15200
https://issues.apache.org/jira/browse/AMBARI-15200

Repository: ambari

Description
-------

Diffs
-----

ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 4faee0e
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 4d8e13b

Diff: https://reviews.apache.org/r/44064/diff/

Testing (updated)
-------

Manual testing: created 3 node cluster and tested the fix with multiple config groups and service configs.

All ambari server unit tests completed fine (branch-2.2 and 2.2.1-main; trunk)

Thanks,

Sebastian Toader