You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by "Gerhard Petracek (JIRA)" <ji...@apache.org> on 2012/07/31 17:30:33 UTC
[jira] [Created] (DELTASPIKE-255) base class for extensions
Gerhard Petracek created DELTASPIKE-255:
-------------------------------------------
Summary: base class for extensions
Key: DELTASPIKE-255
URL: https://issues.apache.org/jira/browse/DELTASPIKE-255
Project: DeltaSpike
Issue Type: Improvement
Components: Core
Affects Versions: 0.3-incubating
Reporter: Gerhard Petracek
Assignee: Gerhard Petracek
Fix For: 0.4-incubating
in myfaces codi we have
/**
* Returns if the current instance is active or not.
*
* @return true if the current instance is active, false otherwise
*/
boolean isActivated();
in Deactivatable to keep it more obvious where the logic for the de-/activation is located.
in deltaspike we don't have this method any longer, but we could use an abstract class which contains our generic observer implementation - instead of c&p
protected void init(@Observes BeforeBeanDiscovery beforeBeanDiscovery)
{
isActivated = ClassDeactivationUtils.isActivated(getClass());
}
for every extension.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DELTASPIKE-255) base class for extensions
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg resolved DELTASPIKE-255.
--------------------------------------
Resolution: Won't Fix
We have quite some Extensions which themself do a @Observes BeforeBeanDiscovery.
Moving the isactivated handling to an own observer method would introduce timing issues as it is not defined which of n event observers get notified first. This would also have a performance drawback as we would duplicate the number of observers for those methods.
> base class for extensions
> -------------------------
>
> Key: DELTASPIKE-255
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-255
> Project: DeltaSpike
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.3-incubating
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 0.4-incubating
>
>
> in myfaces codi we have
> /**
> * Returns if the current instance is active or not.
> *
> * @return true if the current instance is active, false otherwise
> */
> boolean isActivated();
> in Deactivatable to keep it more obvious where the logic for the de-/activation is located.
> in deltaspike we don't have this method any longer, but we could use an abstract class which contains our generic observer implementation - instead of c&p
> protected void init(@Observes BeforeBeanDiscovery beforeBeanDiscovery)
> {
> isActivated = ClassDeactivationUtils.isActivated(getClass());
> }
> for every extension.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-255) base class for extensions
Posted by "Romain Manni-Bucau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425850#comment-13425850 ]
Romain Manni-Bucau commented on DELTASPIKE-255:
-----------------------------------------------
If we want something like that maybe DS extensions shouldn't be cdi extensions...seems weird but more logical. This way the on/off mode is easy to manage.
maybe we should discuss about it, no?
> base class for extensions
> -------------------------
>
> Key: DELTASPIKE-255
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-255
> Project: DeltaSpike
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.3-incubating
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 0.4-incubating
>
>
> in myfaces codi we have
> /**
> * Returns if the current instance is active or not.
> *
> * @return true if the current instance is active, false otherwise
> */
> boolean isActivated();
> in Deactivatable to keep it more obvious where the logic for the de-/activation is located.
> in deltaspike we don't have this method any longer, but we could use an abstract class which contains our generic observer implementation - instead of c&p
> protected void init(@Observes BeforeBeanDiscovery beforeBeanDiscovery)
> {
> isActivated = ClassDeactivationUtils.isActivated(getClass());
> }
> for every extension.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira