[jira] [Commented] (YARN-1351) Invalid string format in Fair Scheduler log warn message

["Konstantin Weitz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872698#comment-13872698 ] 

Konstantin Weitz commented on YARN-1351:
----------------------------------------

Because of the simplicity of the fix, writing a test case would not be worthwhile. Because of the locality and size of the change, I used manual inspection to verify that the patch fixes the problem and does not introduce new problems. 

Sandy Ryza, do agree with this reasoning, or do you have any suggestions on how to improve the patch?

> Invalid string format in Fair Scheduler log warn message
> --------------------------------------------------------
>
>                 Key: YARN-1351
>                 URL: https://issues.apache.org/jira/browse/YARN-1351
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>            Reporter: Konstantin Weitz
>         Attachments: fixprnt.patch
>
>
> While trying to print a warning, two values of the wrong type (Resource instead of int) are passed into a String.format method call, leading to a runtime exception, in the file:
> _trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java_.
> The warning was intended to be printed whenever the resources don't fit into each other, either because the number of virtual cores or the memory is too small. I changed the %d's into %s, this way the warning will contain both the cores and the memory.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)