[jira] [Commented] (IMPALA-13456) Calcite planner: Fix issues with quotes

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-13456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891039#comment-17891039 ] 

ASF subversion and git services commented on IMPALA-13456:
----------------------------------------------------------

Commit d2cb00cecea1883955a5bc4be997567bb04be0f8 in impala's branch refs/heads/master from Steve Carlin
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=d2cb00cec ]

IMPALA-13456: Calcite planner: fix issues with quotes

Changed the parser to use quotes that are inline with how Impala
treats quotes, including allowing single quotes, double quotes,
and back ticks for aliases, and also allowing the backslash
to be used as an escape character.  This is inline with what
BigQuery uses in Calcite.

A couple of unit tests were added, but these will be tested more
extensively by the ParserTest frontend unit test when that gets
committed.

Also, added the VALUE as a nonreserved keyword which is used in
the tpcds queries (along with the doublequotes)

Change-Id: I67ebb19912714c240b99a42d9f2f02f78c189350
Reviewed-on: http://gerrit.cloudera.org:8080/21942
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Michael Smith <mi...@cloudera.com>


> Calcite planner: Fix issues with quotes
> ---------------------------------------
>
>                 Key: IMPALA-13456
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13456
>             Project: IMPALA
>          Issue Type: Sub-task
>            Reporter: Steve Carlin
>            Priority: Major
>             Fix For: Impala 4.5.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org