[jira] [Closed] (TINKERPOP-1596) TinkerGraphComputer does not shutdown ComputerService Executor

["stephen mallette (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TINKERPOP-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stephen mallette closed TINKERPOP-1596.
---------------------------------------
       Resolution: Fixed
    Fix Version/s: 3.2.5

It appears that this was fixed on 3.2.5 here via CTR:

https://github.com/apache/tinkerpop/commit/df285d38027d46f5dcabf4ce5831b6028624bc9f

I guess it wasn't noticed that there was a ticket for this issue

> TinkerGraphComputer does not shutdown ComputerService Executor
> --------------------------------------------------------------
>
>                 Key: TINKERPOP-1596
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1596
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: tinkergraph
>    Affects Versions: 3.2.3
>            Reporter: Ted Wilmes
>            Assignee: Ted Wilmes
>             Fix For: 3.2.5
>
>
> I haven't seen any issues in normal usage, but while benchmarking `TinkerGraphComputer` with JMH, I noticed the forked JVM was hanging and had to be forcibly killed by JMH.
> {code}
> Thread[TinkerGraphComputer-boss,5,main]
>   at sun.misc.Unsafe.park(Native Method)
>   at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
>   at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
>   at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
>   at java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1067)
>   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1127)
>   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> <JMH had finished, but forked VM did not exit, are there stray running threads? Waiting 19 seconds more...>
> {code}
> The {{TinkerWorkerPool}} is being closed but not the {{ComputerService}} which causes the hang.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)