You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by alpinegizmo <gi...@git.apache.org> on 2017/01/31 14:39:00 UTC
[GitHub] flink pull request #3242: [FLINK-5575][docs] reworked the mechanism that war...
GitHub user alpinegizmo opened a pull request:
https://github.com/apache/flink/pull/3242
[FLINK-5575][docs] reworked the mechanism that warns users about \u2026
\u2026newer docs so that only the most recent out-of-date release has to be updated when a new release is made available.
Defining latest_stable_url wasn't a very scalable approach, since this value would have to be updated in every old release. This has been replaced with a redirect from flink.apache.org/q/stable-docs.html.
It would make sense to merge this PR into the release-1.2 branch, though it isn't strictly necessary.
Also, release-1.1 will need to be updated when 1.2 is released.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alpinegizmo/flink old-doc-warning
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3242.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3242
----
commit dcf9b96205c604cb2665d1e9bf6ed1d5897910ad
Author: David Anderson <da...@alpinegizmo.com>
Date: 2017-01-31T14:15:15Z
[FLINK-5575][docs] reworked the mechanism that warns users about newer docs so that only the most recent out-of-date release has to be updated when a new release is available
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3242: [FLINK-5575][docs] reworked the mechanism that warns user...
Posted by alpinegizmo <gi...@git.apache.org>.
Github user alpinegizmo commented on the issue:
https://github.com/apache/flink/pull/3242
@uce Some old releases still have strong google power -- especially 0.8. I don't know if replacing those pages with a redirect will cause the page rank to plummet or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3242: [FLINK-5575][docs] reworked the mechanism that warns user...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3242
Good addition. Could you post a screenshot of how this looks now?
Given that we are very unlikely to provide any fixes for older versions than 1.0.0, I would vote to simply redirect to the latest stable version instead of still hosting the docs for those versions; especially because the docs before 1.0.0 are in very bad shape. If any user is interested in those docs, it's possible to check out the source code and manually build them. What do you think?
@rmetzger Would it be possible to have a redirect via the `ci` infra?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3242: [FLINK-5575][docs] reworked the mechanism that warns user...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3242
Merging this with the other PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3242: [FLINK-5575][docs] reworked the mechanism that warns user...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3242
Looks very nice. +1 to the design.
Let's merge this as is and decide whether we remove the older pages later then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3242: [FLINK-5575][docs] reworked the mechanism that war...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3242
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3242: [FLINK-5575][docs] reworked the mechanism that warns user...
Posted by alpinegizmo <gi...@git.apache.org>.
Github user alpinegizmo commented on the issue:
https://github.com/apache/flink/pull/3242
@uce I tried to choose styling that looks decent with all previous releases. Here's a screenshot against 1.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---