You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Paul Brett <pa...@twopensource.com> on 2015/03/31 23:55:40 UTC
Review Request 32658: Report errors from mesos-network-helper in JSON
output stream so that we can catch and process them in the caller.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32658/
-----------------------------------------------------------
Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332
Repository: mesos
Description
-------
Report pid & errors from mesos-network-helper in JSON output fields.
Diffs
-----
src/slave/containerizer/isolators/network/port_mapping.cpp e691d46
Diff: https://reviews.apache.org/r/32658/diff/
Testing
-------
make check
Thanks,
Paul Brett
Re: Review Request 32658: Report errors from mesos-network-helper in
JSON
output stream so that we can catch and process them in the caller.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32658/#review78417
-----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/32658/#comment127069>
`pid` is passed from the parent process. Why do you want to report it back?
- Jie Yu
On March 31, 2015, 9:55 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32658/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 9:55 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
>
>
> Bugs: mesos-2332
> https://issues.apache.org/jira/browse/mesos-2332
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Report pid & errors from mesos-network-helper in JSON output fields.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp e691d46
>
> Diff: https://reviews.apache.org/r/32658/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 32658: Report errors from mesos-network-helper in
JSON
output stream so that we can catch and process them in the caller.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32658/#review78412
-----------------------------------------------------------
What's the motivation for this patch? You want to catch the error message in the caller and then print them?
- Jie Yu
On March 31, 2015, 9:55 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32658/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 9:55 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
>
>
> Bugs: mesos-2332
> https://issues.apache.org/jira/browse/mesos-2332
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Report pid & errors from mesos-network-helper in JSON output fields.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp e691d46
>
> Diff: https://reviews.apache.org/r/32658/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 32658: Report errors from mesos-network-helper in
JSON
output stream so that we can catch and process them in the caller.
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32658/
-----------------------------------------------------------
(Updated April 1, 2015, 12:45 a.m.)
Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332
Repository: mesos
Description
-------
Report pid & errors from mesos-network-helper in JSON output fields.
Diffs (updated)
-----
src/slave/containerizer/isolators/network/port_mapping.cpp e691d463515084518c94cdec3fbdf37be4a72977
Diff: https://reviews.apache.org/r/32658/diff/
Testing
-------
make check
Thanks,
Paul Brett