You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by miguelaferreira <gi...@git.apache.org> on 2015/12/28 16:11:39 UTC

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

GitHub user miguelaferreira opened a pull request:

    https://github.com/apache/cloudstack/pull/1292

    Add Health Check Command to NSX plugin

    The NSX plugin does not support the HeathCheckCommand. Instead it fakes a PingCommand as a call tot he control cluster status API.
    However, we have seen in production that the management server will sometimes find the NSX controller to be behind on ping and that will trigger a HealthCheckCommand which will return with an unsupported command answer.
    Once this happens the controller is put into Alert state and will not recover until the management sever is restarted.
    
    In addition, during the investigation, there will be a null pointer exception due tot he fact that the NSX controllers do not live in a pod.
    
    This PR tries to address those two issues.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/miguelaferreira/cloudstack nsx-heath-check

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1292.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1292
    
----
commit 1cc610f617bfa99663701e81216f76258eafb54e
Author: Miguel Ferreira <mi...@me.com>
Date:   2015-12-28T09:37:33Z

    Prevent NullPointerException when host does not belong to a pod
    
    NSX controllers are hosts that do not belong in a Pod.
    When investigators kick-in an exception is thrown because of the
    missing pod foreign key.

commit 13f1ed7f147f67974102525c1cd9bfc6503e78eb
Author: Miguel Ferreira <mi...@me.com>
Date:   2015-12-28T10:07:10Z

    Fix log message that refers to agent, not host

commit 47a23c22c1d3bd6a195b0a752cfc9ad5f2b78f22
Author: Miguel Ferreira <mi...@me.com>
Date:   2015-12-28T13:27:27Z

    Implement CheckHealthCommand for NSX controllers

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:

    https://github.com/apache/cloudstack/pull/1292#issuecomment-167586010
  
    closing since this should not target master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira closed the pull request at:

    https://github.com/apache/cloudstack/pull/1292


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---